From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:54925 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbdJNXfu (ORCPT ); Sat, 14 Oct 2017 19:35:50 -0400 Received: by mail-pg0-f68.google.com with SMTP id l24so3916365pgu.11 for ; Sat, 14 Oct 2017 16:35:50 -0700 (PDT) Date: Sun, 15 Oct 2017 08:35:47 +0900 Message-ID: <87shel9ub0.wl-satoru.takeuchi@gmail.com> From: Satoru Takeuchi To: dsterba@suse.cz, Satoru Takeuchi , Mike Fleetwood , linux-btrfs Subject: Re: [PATCH v2] btrfs-progs: allow "none" to disable compression for convenience In-Reply-To: <20170919151427.GH29043@twin.jikos.cz> References: <87poaqyxdi.wl-satoru.takeuchi@gmail.com> <8760cgalea.wl-satoru.takeuchi@gmail.com> <20170919151427.GH29043@twin.jikos.cz> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-btrfs-owner@vger.kernel.org List-ID: At Tue, 19 Sep 2017 17:14:27 +0200, David Sterba wrote: > > On Mon, Sep 18, 2017 at 09:41:17AM +0900, Satoru Takeuchi wrote: > > At Sun, 17 Sep 2017 14:08:40 +0100, > > Mike Fleetwood wrote: > > > > > > On 17 September 2017 at 01:36, Satoru Takeuchi > > > wrote: > > > > It's messy to use "" to disable compression. Introduce the new value "no" > > > > which can also be used for this purpose. > > > > > > From an English language point of view, "none" would be better. None > > > says the absence of, where as no is more general negative. > > > > Thank you for your comment. How about is it? > > > > --- > > It's messy to use "" to disable compression. Introduce the new value "none" > > which can also be used for this purpose. > > I'd allow both values, 'no' and 'none', similar to the mount options, > that also accept both (technically, the 'no' + anything is accepted for > disabling compression). But only "no" is writtein in man 5 btrfs.