linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Huang\, Ying" <ying.huang@intel.com>
To: Chris Mason <clm@fb.com>
Cc: Josef Bacik <jbacik@fb.com>, David Sterba <dsterba@suse.com>,
	<lkp@01.org>, <linux-btrfs@vger.kernel.org>
Subject: Re: [LKP] [lkp-robot] [mm] 9092c71bb7: blogbench.write_score -12.3% regression
Date: Thu, 21 Jun 2018 08:38:46 +0800	[thread overview]
Message-ID: <87vaadgei1.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <B33D77FE-E654-4BB3-A7F3-CEBCE93C6589@fb.com> (Chris Mason's message of "Wed, 20 Jun 2018 08:38:45 -0400")

Chris Mason <clm@fb.com> writes:

> On 19 Jun 2018, at 23:51, Huang, Ying wrote:
>>>> "Huang, Ying" <ying.huang@intel.com> writes:
>>>>
>>>>> Hi, Josef,
>>>>>
>>>>> Do you have time to take a look at the regression?
>>>>>
>>>>> kernel test robot <xiaolong.ye@intel.com> writes:
>>>>>
>>>>>> Greeting,
>>>>>>
>>>>>> FYI, we noticed a -12.3% regression of blogbench.write_score and
>>>>>> a +9.6% improvement
>>>>>> of blogbench.read_score due to commit:
>>>>>>
>>>>>>
>>>>>> commit: 9092c71bb724dba2ecba849eae69e5c9d39bd3d2 ("mm: use
>>>>>> sc->priority for slab shrink targets")
>>>>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git
>>>>>> master
>>>>>>
>>>>>> in testcase: blogbench
>>>>>> on test machine: 16 threads Intel(R) Xeon(R) CPU D-1541 @
>>>>>> 2.10GHz with 8G memory
>>>>>> with following parameters:
>>>>>>
>>>>>> 	disk: 1SSD
>>>>>> 	fs: btrfs
>>>>>> 	cpufreq_governor: performance
>>>>>>
>>>>>> test-description: Blogbench is a portable filesystem benchmark
>>>>>> that tries to reproduce the load of a real-world busy file
>>>>>> server.
>>>>>> test-url:
>
> I'm surprised, this patch is a big win in production here at FB.  I'll
> have to reproduce these results to better understand what is going on.
> My first guess is that since we have fewer inodes in slab, we're
> reading more inodes from disk in order to do the writes.
>
> But that should also make our read scores lower.

Thanks for looking at this.  If you need more information, please let me
know.

Best Regards,
Huang, Ying


  reply	other threads:[~2018-06-21  0:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180408015739.GN3845@yexl-desktop>
2018-05-29  7:30 ` [LKP] [lkp-robot] [mm] 9092c71bb7: blogbench.write_score -12.3% regression Huang, Ying
2018-06-05  4:58   ` Huang, Ying
2018-06-14  1:37     ` Huang, Ying
2018-06-20  3:51       ` Huang, Ying
2018-06-20 12:38         ` Chris Mason
2018-06-21  0:38           ` Huang, Ying [this message]
2018-07-13  1:55           ` Huang, Ying
2018-08-02  5:55             ` Huang, Ying
2018-08-02 16:23               ` Josef Bacik
2018-08-03  8:22                 ` Huang, Ying
2018-08-29  6:55                   ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vaadgei1.fsf@yhuang-dev.intel.com \
    --to=ying.huang@intel.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=lkp@01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).