From: Andi Kleen <andi@firstfloor.org>
To: Jim Meyering <jim@meyering.net>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: avoid NULL deref after failed allocation
Date: Thu, 02 Oct 2008 17:15:30 +0200 [thread overview]
Message-ID: <87y717ni3x.fsf@basil.nowhere.org> (raw)
In-Reply-To: <87abdnt62c.fsf@rho.meyering.net> (Jim Meyering's message of "Thu, 02 Oct 2008 16:39:07 +0200")
Jim Meyering <jim@meyering.net> writes:
> However, in some places, the trend is
> to BUG_ON(!ptr), so I've done that, too.
Even if it's a trend, it's wrong. Better don't add more.
And also unnecessary because next reference will obviously oops anyways.
-Andi
prev parent reply other threads:[~2008-10-02 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 14:39 [PATCH] Btrfs: avoid NULL deref after failed allocation Jim Meyering
2008-10-02 15:15 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y717ni3x.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=jim@meyering.net \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox