From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Christoph Hellwig <hch@lst.de>
Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: use kvcalloc in btrfs_get_dev_zone_info
Date: Mon, 21 Nov 2022 16:46:55 +0900 [thread overview]
Message-ID: <893acfcf-59d6-07c2-0c21-1de124c8eafe@opensource.wdc.com> (raw)
In-Reply-To: <20221121070518.GD23563@lst.de>
On 11/21/22 16:05, Christoph Hellwig wrote:
> On Mon, Nov 21, 2022 at 11:31:01AM +0900, Damien Le Moal wrote:
>> Looks good.
>> This likely needs a fixes tag though.
>
> git-blame seems to suggest the code has been like this since the
> addition of the zone code. Which is a bit odd as I've not seen
> the issue before last week.
BTRFS_REPORT_NR_ZONES is 4096, so the allocation is for 256KiB (4096 x
64B). Not that small, but the mm code can likely handle that most of the
time. I guess we were all lucky until now :)
So maybe simply add:
Fixes: 5b316468983d ("btrfs: get zone information of zoned block devices")
No ?
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-11-21 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 12:43 [PATCH] btrfs: use kvcalloc in btrfs_get_dev_zone_info Christoph Hellwig
2022-11-21 2:31 ` Damien Le Moal
2022-11-21 7:05 ` Christoph Hellwig
2022-11-21 7:46 ` Damien Le Moal [this message]
2022-11-21 7:45 ` Johannes Thumshirn
2022-11-21 17:42 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=893acfcf-59d6-07c2-0c21-1de124c8eafe@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox