From: Nikolay Borisov <nborisov@suse.com>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>, linux-btrfs@vger.kernel.org
Cc: Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH] btrfs: Evaluate io_tree in find_lock_delalloc_range()
Date: Wed, 19 Jun 2019 09:05:32 +0300 [thread overview]
Message-ID: <8a7dd8d7-a918-b618-d8e2-bf0ff182cfdc@suse.com> (raw)
In-Reply-To: <20190619003524.32377-1-rgoldwyn@suse.de>
On 19.06.19 г. 3:35 ч., Goldwyn Rodrigues wrote:
> Simplification.
> No point passing the tree variable when it can be evaluated
> from inode.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
The patch is good, however, there are several calls to find_
lock_delalloc_range in btrfs tests so you'd need to fix those
invocations, otherwise compilation of the in-kernel test suite will fails.
fs/btrfs/tests/extent-io-tests.c: found = find_lock_delalloc_range(inode, &tmp, locked_page, &start,
fs/btrfs/tests/extent-io-tests.c: found = find_lock_delalloc_range(inode, &tmp, locked_page, &start,
fs/btrfs/tests/extent-io-tests.c: found = find_lock_delalloc_range(inode, &tmp, locked_page, &start,
fs/btrfs/tests/extent-io-tests.c: found = find_lock_delalloc_range(inode, &tmp, locked_page, &start,
fs/btrfs/tests/extent-io-tests.c: found = find_lock_delalloc_range(inode, &tmp, locked_page, &start,
> ---
> fs/btrfs/extent_io.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index db337e53aab3..e9475d7e11bf 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -1719,10 +1719,10 @@ static noinline int lock_delalloc_pages(struct inode *inode,
> */
> EXPORT_FOR_TESTS
> noinline_for_stack bool find_lock_delalloc_range(struct inode *inode,
> - struct extent_io_tree *tree,
> struct page *locked_page, u64 *start,
> u64 *end)
> {
> + struct extent_io_tree *tree = &BTRFS_I(inode)->io_tree;
> u64 max_bytes = BTRFS_MAX_EXTENT_SIZE;
> u64 delalloc_start;
> u64 delalloc_end;
> @@ -3290,7 +3290,6 @@ static noinline_for_stack int writepage_delalloc(struct inode *inode,
> struct page *page, struct writeback_control *wbc,
> u64 delalloc_start, unsigned long *nr_written)
> {
> - struct extent_io_tree *tree = &BTRFS_I(inode)->io_tree;
> u64 page_end = delalloc_start + PAGE_SIZE - 1;
> bool found;
> u64 delalloc_to_write = 0;
> @@ -3300,8 +3299,7 @@ static noinline_for_stack int writepage_delalloc(struct inode *inode,
>
>
> while (delalloc_end < page_end) {
> - found = find_lock_delalloc_range(inode, tree,
> - page,
> + found = find_lock_delalloc_range(inode, page,
> &delalloc_start,
> &delalloc_end);
> if (!found) {
>
next prev parent reply other threads:[~2019-06-19 6:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 0:35 [PATCH] btrfs: Evaluate io_tree in find_lock_delalloc_range() Goldwyn Rodrigues
2019-06-19 6:05 ` Nikolay Borisov [this message]
2019-06-19 11:36 ` Goldwyn Rodrigues
2019-06-19 13:09 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2019-06-21 15:02 Goldwyn Rodrigues
2019-07-01 15:52 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a7dd8d7-a918-b618-d8e2-bf0ff182cfdc@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).