Re: [PATCH v3.1 1/7] btrfs: Introduce a function to check if all chunks a OK for degraded rw mount

[Anand Jain <anand.jain@oracle.com>]

On 05/02/2017 08:20 AM, Qu Wenruo wrote:
>
>
> At 05/01/2017 06:21 PM, Dmitrii Tcvetkov wrote:
>>>>> +bool btrfs_check_rw_degradable(struct btrfs_fs_info *fs_info)
>>>>> +{
>>>>> +    struct btrfs_mapping_tree *map_tree = &fs_info->mapping_tree;
>>>>> +    struct extent_map *em;
>>>>> +    u64 next_start = 0;
>>>>> +    bool ret = true;
>>>>> +
>>>>> +    read_lock(&map_tree->map_tree.lock);
>>>>> +    em = lookup_extent_mapping(&map_tree->map_tree, 0, (u64)-1);
>>>>> +    read_unlock(&map_tree->map_tree.lock);
>>>>> +    /* No chunk at all? Return false anyway */
>>>>> +    if (!em) {
>>>>> +        ret = false;
>>>>> +        goto out;
>>>>> +    }
>>>>> +    while (em) {
>>>>> +        struct map_lookup *map;
>>>>> +        int missing = 0;
>>>>> +        int max_tolerated;
>>>>> +        int i;
>>>>> +
>>>>> +        map = (struct map_lookup *) em->bdev;
>>>>
>>>>
>>>>     any idea why not   map = em->map_lookup;  here?
>>>
>>>
>>> My fault, will update the patch.
>>>
>>> Thanks,
>>> Qu
>>
>> Sorry to bother, but looks like this patchset suddenly got forgotten.
>> It still applies to 4.11 but I'm afraid it won't after 4.12 merge
>> window. Any update on it?
>
> Just waiting for the flush error rework from Anand Jain.


   There were quite a number of trials on the btrfs dev flush to get
   that correctly, David reviewed previous once and the current and
   probably the final is titled [1] which is waiting for David.
     [1]
     [PATCH] btrfs: add framework to handle device flush error as a volume

Thanks, Anand


> (Well, I still remember the original patchset has the same thing problem)
>
> Maybe Anand Jain has some idea on this.
>
> Thanks,
> Qu