Re: BTRFS corruption after conversion to block group tree

Qu Wenruo
2023-12-02T09:00:40Z

On 2023/12/2 18:34, Russell Haley wrote:
>
>
> On 12/2/23 00:43, Qu Wenruo wrote:
>>
>>
>> On 2023/12/2 16:43, Russell Haley wrote:
>>> To be clear, there is no reason to be suspicious of the other disk that
>>> was converted to block group tree and has passed a scrub after
>>> rebooting? It should be safe to mount that one read-write again?
>>
>> Scrub is only checksum verification, no comprehensive extent tree
>> cross-check like `btrfs check`.
>>
>> If we really screwed up the block group tree conversion, btrfs check
>> should be able to expose it.
>>
>> Thus that's why I'm going to add "btrfs check" runs before and after
>> block group tree conversion.
>>
>> Just remember, scrub is never as good as "btrfs check".
>
> Thanks. `btrfs check` passed too, so I've removed `ro` from fstab.
>
Then it looks like it's less possible that I screwed up, or we're
hitting a really corner case that only certain layout is affected.

Anyway, more `btrfs check` never hurts (except someone is super impatient)

Thanks,
Qu