From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 02/15] btrfs: use min() to replace open-code in btrfs_invalidatepage()
Date: Mon, 15 Mar 2021 20:03:12 +0800 [thread overview]
Message-ID: <8df46a0e-88e1-79fe-cb0c-00a5aa3271a7@oracle.com> (raw)
In-Reply-To: <20210310090833.105015-3-wqu@suse.com>
On 10/03/2021 17:08, Qu Wenruo wrote:
> In btrfs_invalidatepage() we introduce a temporary variable, new_len, to
> update ordered->truncated_len.
>
> But we can use min() to replace it completely and no need for the
> variable.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
Reviewed-by: Anand Jain <anand.jain@oracle.com>
-Anand
> fs/btrfs/inode.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 52dc5f52ea58..2973cec05505 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -8405,15 +8405,13 @@ static void btrfs_invalidatepage(struct page *page, unsigned int offset,
> */
> if (TestClearPagePrivate2(page)) {
> struct btrfs_ordered_inode_tree *tree;
> - u64 new_len;
>
> tree = &inode->ordered_tree;
>
> spin_lock_irq(&tree->lock);
> set_bit(BTRFS_ORDERED_TRUNCATED, &ordered->flags);
> - new_len = start - ordered->file_offset;
> - if (new_len < ordered->truncated_len)
> - ordered->truncated_len = new_len;
> + ordered->truncated_len = min(ordered->truncated_len,
> + start - ordered->file_offset);
> spin_unlock_irq(&tree->lock);
>
> if (btrfs_dec_test_ordered_pending(inode, &ordered,
>
next prev parent reply other threads:[~2021-03-15 12:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 9:08 [PATCH v2 00/15] btrfs: support read-write for subpage metadata Qu Wenruo
2021-03-10 9:08 ` [PATCH v2 01/15] btrfs: add sysfs interface for supported sectorsize Qu Wenruo
2021-03-15 11:59 ` Anand Jain
2021-03-15 12:39 ` Qu Wenruo
2021-03-15 18:44 ` David Sterba
2021-03-16 0:05 ` Qu Wenruo
2021-03-16 0:10 ` Anand Jain
2021-03-16 10:25 ` David Sterba
2021-03-16 10:27 ` David Sterba
2021-03-10 9:08 ` [PATCH v2 02/15] btrfs: use min() to replace open-code in btrfs_invalidatepage() Qu Wenruo
2021-03-15 12:03 ` Anand Jain [this message]
2021-03-10 9:08 ` [PATCH v2 03/15] btrfs: remove unnecessary variable shadowing " Qu Wenruo
2021-03-15 12:06 ` Anand Jain
2021-03-10 9:08 ` [PATCH v2 04/15] btrfs: introduce helpers for subpage dirty status Qu Wenruo
2021-03-10 9:08 ` [PATCH v2 05/15] btrfs: introduce helpers for subpage writeback status Qu Wenruo
2021-03-10 9:08 ` [PATCH v2 06/15] btrfs: allow btree_set_page_dirty() to do more sanity check on subpage metadata Qu Wenruo
2021-03-10 9:08 ` [PATCH v2 07/15] btrfs: support subpage metadata csum calculation at write time Qu Wenruo
2021-03-10 9:08 ` [PATCH v2 08/15] btrfs: make alloc_extent_buffer() check subpage dirty bitmap Qu Wenruo
2021-03-10 9:08 ` [PATCH v2 09/15] btrfs: make the page uptodate assert to be subpage compatible Qu Wenruo
2021-03-10 9:08 ` [PATCH v2 10/15] btrfs: make set/clear_extent_buffer_dirty() " Qu Wenruo
2021-03-10 9:08 ` [PATCH v2 11/15] btrfs: make set_btree_ioerr() accept extent buffer and " Qu Wenruo
2021-03-10 9:08 ` [PATCH v2 12/15] btrfs: introduce end_bio_subpage_eb_writepage() function Qu Wenruo
2021-03-10 9:08 ` [PATCH v2 13/15] btrfs: introduce write_one_subpage_eb() function Qu Wenruo
2021-03-10 9:08 ` [PATCH v2 14/15] btrfs: make lock_extent_buffer_for_io() to be subpage compatible Qu Wenruo
2021-03-10 9:08 ` [PATCH v2 15/15] btrfs: introduce submit_eb_subpage() to submit a subpage metadata page Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8df46a0e-88e1-79fe-cb0c-00a5aa3271a7@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox