From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Long An <lan@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs-progs: tests: mkfs/011: Fix path for rootdir
Date: Fri, 20 Dec 2019 14:09:12 +0800 [thread overview]
Message-ID: <8f45b38d-753a-78e9-8d59-6ae6bf39ff7a@gmx.com> (raw)
In-Reply-To: <20191218161919.GM3929@twin.jikos.cz>
[-- Attachment #1.1: Type: text/plain, Size: 533 bytes --]
On 2019/12/19 上午12:19, David Sterba wrote:
> On Tue, Dec 17, 2019 at 06:36:51AM +0000, Long An wrote:
>> Documentation folder path is wrong on exported testsutie. Fix this by
>> replace TOP with INTERNAL_BIN.
>
> It feels wrong that the tests use INTERNAL_BIN but it obviously exists
> and works so I'll apply the patch but maybe this could use some cleanup.
> Thanks.
>
The patch itself is kinda OK, but I guess we'd better to have some file
generation function to test mkfs.btrfs --rootdir.
Thanks,
Qu
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-12-20 6:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 6:36 [PATCH] btrfs-progs: tests: mkfs/011: Fix path for rootdir Long An
2019-12-18 16:19 ` David Sterba
2019-12-20 6:09 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f45b38d-753a-78e9-8d59-6ae6bf39ff7a@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.cz \
--cc=lan@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox