Re: [PATCH next v2 08/11] minmax: Add min_const() and max_const()

Dave Airlie
2024-02-26T01:11:23Z

On Mon, 26 Feb 2024 at 07:26, David Laight <David.Laight@aculab.com> wrote:
>
> ...
> > Yes, yes, that may end up requiring getting rid of some current users of
> >
> > #define MIN(a,b) ((a)<(b) ? (a):(b))
> >
> > but dammit, we don't actually have _that_ many of them, and why should
> > we have random drivers doing that anyway?
>
> They look like they could be changed to min().
> It is even likely the header gets pulled in somewhere.
>
> I'm not sure about the ones in drivers/gpu/drm/amd/display/*..*/*.c, but it
> wouldn't surprise me if that code doesn't use any standard kernel headers.
> Isn't that also the code that manages to pass 42 integer parameters
> to functions?

They are all separate in C files, I think we could get rid of them
pretty easily in favour of the standard ones,

Adding Harry to cc.

Dave.