Re: [PATCH 4/9] btrfs: rename btrfs_add_delalloc_inodes() to singular form

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

On 2024/2/10 04:30, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> The function btrfs_add_delalloc_inodes() adds a single inode its root's
> list of delalloc inodes, so it doesn't make any sense at all for the
> function's name to be plural. Rename it to the singular form
> btrfs_add_delalloc_inode() to avoid any confusion.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   fs/btrfs/inode.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 3a19e30676e8..b273fdbd63cd 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -2385,7 +2385,7 @@ void btrfs_merge_delalloc_extent(struct btrfs_inode *inode, struct extent_state
>   	spin_unlock(&inode->lock);
>   }
>
> -static void btrfs_add_delalloc_inodes(struct btrfs_inode *inode)
> +static void btrfs_add_delalloc_inode(struct btrfs_inode *inode)
>   {
>   	struct btrfs_root *root = inode->root;
>   	struct btrfs_fs_info *fs_info = root->fs_info;
> @@ -2472,7 +2472,7 @@ void btrfs_set_delalloc_extent(struct btrfs_inode *inode, struct extent_state *s
>   			inode->defrag_bytes += len;
>   		if (do_list && !test_bit(BTRFS_INODE_IN_DELALLOC_LIST,
>   					 &inode->runtime_flags))
> -			btrfs_add_delalloc_inodes(inode);
> +			btrfs_add_delalloc_inode(inode);
>   		spin_unlock(&inode->lock);
>   	}
>