From: Josef Bacik <josef@toxicpanda.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Consolidate btrfs_previous_item ret val handling in btrfs_shrink_device
Date: Thu, 17 Dec 2020 09:44:29 -0500 [thread overview]
Message-ID: <911d913e-fa0e-e98c-8a34-50aace475b7a@toxicpanda.com> (raw)
In-Reply-To: <20201217132116.328291-1-nborisov@suse.com>
On 12/17/20 8:21 AM, Nikolay Borisov wrote:
> Instead of having 3 'if' to handle non-null return value consolidate
> this in 1 'if (ret)'. That way the code is more obvious:
>
> - Always drop dlete_unused_bgs_mutex if ret is non null
> - If ret is negative -> goto done
> - If it's 1 -> reset ret to 0, release the path and finish the loop.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
next prev parent reply other threads:[~2020-12-17 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 13:21 [PATCH] btrfs: Consolidate btrfs_previous_item ret val handling in btrfs_shrink_device Nikolay Borisov
2020-12-17 14:44 ` Josef Bacik [this message]
2020-12-21 17:02 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=911d913e-fa0e-e98c-8a34-50aace475b7a@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox