linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Borisov <nborisov@suse.com>
To: Lu Fengqi <lufq.fnst@cn.fujitsu.com>, enadolski@suse.com
Cc: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove spurious WARN_ON(ref->count) in find_parent_nodes
Date: Mon, 22 Jan 2018 10:46:37 +0200	[thread overview]
Message-ID: <9151459e-8db2-bdd1-a21e-23d730cb52a4@suse.com> (raw)
In-Reply-To: <20180122033452.GA532@fnst.localdomain>



On 22.01.2018 05:34, Lu Fengqi wrote:
> According to my bisect result, The frequency of the warning occurrence
> increased to the detectable degree after this patch

That sentence implies that even before Ed's patch it was possible to
trigger those warnings, is that true? Personally I've never seen such
warnings while executing btrfs/004. How do you configure the filesystem
for the test runs?

> 86d5f9944252 ("btrfs: convert prelimary reference tracking to use rbtrees")
> is committed. I understand that this does not mean that this patch caused
> the problem, but maybe Edmund can give us some help, so I added him to the
> recipient.

  reply	other threads:[~2018-01-22  8:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-21 19:08 [PATCH] btrfs: remove spurious WARN_ON(ref->count) in find_parent_nodes Zygo Blaxell
2018-01-22  3:34 ` Lu Fengqi
2018-01-22  8:46   ` Nikolay Borisov [this message]
2018-01-22 12:19     ` Lu Fengqi
2018-01-22 12:38       ` Nikolay Borisov
2018-01-22 13:06         ` Lu Fengqi
2018-01-22 17:58           ` Zygo Blaxell
2018-01-22 16:27   ` Edmund Nadolski
2018-01-22 18:18   ` Zygo Blaxell
2018-01-22 12:58 ` Nikolay Borisov
2018-01-23  3:35   ` Edmund Nadolski
2018-01-23  7:12     ` Nikolay Borisov
2018-01-23  7:36     ` Lu Fengqi
2018-01-23 21:36       ` Edmund Nadolski
2018-01-24  1:31         ` Lu Fengqi
2018-01-24  3:22 ` [PATCH v2] btrfs: remove spurious WARN_ON(ref->count < 0) " Zygo Blaxell
2018-01-24  3:33   ` Lu Fengqi
2018-01-31 15:06     ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9151459e-8db2-bdd1-a21e-23d730cb52a4@suse.com \
    --to=nborisov@suse.com \
    --cc=ce3g8jdj@umail.furryterror.org \
    --cc=enadolski@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=lufq.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).