Re: [PATCH REBASED 1/1] btrfs-progs: inspect-dump-tree: Allow '-b|--block' to be specified multiple times

[Nikolay Borisov <nborisov@suse.com>]

On  1.06.2018 08:15, Qu Wenruo wrote:
> Reuse extent-cache facility to record multiple bytenr so '-b|--block'
> can be specified multiple times.
> 
> Despite that, add a sector size alignment check before we try to print a
> tree block.
> (Please note that, nodesize alignment check is not suitable here as meta
> chunk start bytenr could be unaligned to nodesize)
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Just one minor misspell but otherwise LGTM:

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

> ---
>  Documentation/btrfs-inspect-internal.asciidoc |   2 +-
>  cmds-inspect-dump-tree.c                      | 109 +++++++++++++++---
>  2 files changed, 91 insertions(+), 20 deletions(-)
> 
> diff --git a/Documentation/btrfs-inspect-internal.asciidoc b/Documentation/btrfs-inspect-internal.asciidoc
> index e2db64660b9a..ba8529f57660 100644
> --- a/Documentation/btrfs-inspect-internal.asciidoc
> +++ b/Documentation/btrfs-inspect-internal.asciidoc
> @@ -86,7 +86,7 @@ the respective tree root block offset
>  -u|--uuid::::
>  print only the uuid tree information, empty output if the tree does not exist
>  -b <block_num>::::
> -print info of the specified block only
> +print info of the specified block only, can be specified multiple times.
>  --follow::::
>  use with '-b', print all children tree blocks of '<block_num>'
>  -t <tree_id>::::
> diff --git a/cmds-inspect-dump-tree.c b/cmds-inspect-dump-tree.c
> index 92a2a45b267e..abb9a2bcc7cb 100644
> --- a/cmds-inspect-dump-tree.c
> +++ b/cmds-inspect-dump-tree.c
> @@ -198,11 +198,92 @@ const char * const cmd_inspect_dump_tree_usage[] = {
>  	"-R|--backups           same as --roots plus print backup root info",
>  	"-u|--uuid              print only the uuid tree",
>  	"-b|--block <block_num> print info from the specified block only",
> +	"                       can be specified multile times",
nit: s/multile/multiple