From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 2/2] btrfs: qgroup: Fix bad entry members of qgroup trace events
Date: Thu, 17 Oct 2019 09:33:20 +0300 [thread overview]
Message-ID: <97956f25-e38e-e72a-c02c-138df55231c9@suse.com> (raw)
In-Reply-To: <20191017023837.32264-3-wqu@suse.com>
On 17.10.19 г. 5:38 ч., Qu Wenruo wrote:
> [BUG]
> For btrfs:qgroup_meta_reserve event, the trace event can output garbage:
> qgroup_meta_reserve: 9c7f6acc-b342-4037-bc47-7f6e4d2232d7: refroot=5(FS_TREE) type=DATA diff=2
> qgroup_meta_reserve: 9c7f6acc-b342-4037-bc47-7f6e4d2232d7: refroot=5(FS_TREE) type=0x258792 diff=2
>
> The @type can be completely garbage, as DATA type is not possible for
> trace_qgroup_meta_reserve() trace event.
>
> [CAUSE]
> Ther are several problems related to qgroup trace events:
> - Unassigned entry member
> Member entry::type of trace_qgroup_update_reserve() and
> trace_qgourp_meta_reserve() is not assigned
>
> - Redundant entry member
> Member entry::type is completely useless in
> trace_qgroup_meta_convert()
>
> [FIX]
> Fix these stupid bugs.
>
> Fixes: 4ee0d8832c2e ("btrfs: qgroup: Update trace events for metadata reservation")
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
next prev parent reply other threads:[~2019-10-17 6:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 2:38 [PATCH v2 0/2] btrfs: qgroup: Bug fixes for trace events Qu Wenruo
2019-10-17 2:38 ` [PATCH v2 1/2] btrfs: qgroup: Fix wrong parameter order " Qu Wenruo
2019-10-17 6:37 ` Nikolay Borisov
2019-10-17 2:38 ` [PATCH v2 2/2] btrfs: qgroup: Fix bad entry members of qgroup " Qu Wenruo
2019-10-17 6:33 ` Nikolay Borisov [this message]
2019-10-17 12:09 ` [PATCH v2 0/2] btrfs: qgroup: Bug fixes for " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97956f25-e38e-e72a-c02c-138df55231c9@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox