From: Anand Jain <anand.jain@oracle.com>
To: bo.li.liu@oracle.com
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix false EIO for missing device
Date: Sat, 14 Oct 2017 08:33:55 +0800 [thread overview]
Message-ID: <9baaa634-8d83-f7f4-cbad-04df9f1c2820@oracle.com> (raw)
In-Reply-To: <20171013180111.GB1553@lim.localdomain>
>> - bio->bi_status = BLK_STS_IOERR;
>> + if (atomic_read(&bbio->error) > bbio->max_errors)
>> + bio->bi_status = BLK_STS_IOERR;
>> + else
>> + bio->bi_status = 0;
>
> Thanks for the fix, I'd prefer BLK_STS_OK rather than 0.
>
> With that,
>
> Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Thanks for the review will fix it.
-Anand
> -liubo
next prev parent reply other threads:[~2017-10-14 0:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 13:42 [PATCH] btrfs: fix false EIO for missing device Anand Jain
2017-10-13 18:01 ` Liu Bo
2017-10-14 0:33 ` Anand Jain [this message]
2017-10-14 0:34 ` [PATCH v2] " Anand Jain
2017-10-16 14:29 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9baaa634-8d83-f7f4-cbad-04df9f1c2820@oracle.com \
--to=anand.jain@oracle.com \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).