From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.com, gpiccoli@igalia.com
Subject: Re: [PATCH 0/4] btrfs: sysfs and unsupported temp-fsid features for clones
Date: Sat, 7 Oct 2023 16:00:58 +0530 [thread overview]
Message-ID: <9cfb8122-4956-4032-b9ab-2eea8bb19415@oracle.com> (raw)
In-Reply-To: <20231006150755.GH28758@twin.jikos.cz>
On 10/6/23 23:07, David Sterba wrote:
> On Wed, Oct 04, 2023 at 11:00:23PM +0800, Anand Jain wrote:
>> Seed and device-add are the two features that must be unsupported
>> if a cloned device is using temp-fsid to mount, as they conflict
>> with multi-device functionality.
>>
>> Additionally, add sysfs files for the temp-fsid feature.
>>
>> Anand Jain (4):
>> btrfs: comment for temp-fsid, fsid, and metadata_uuid
>> btrfs: disable seed feature for temp-fsid
>> btrfs: disable the device add feature for temp-fsid
>> btrfs: show temp_fsid feature in sysfs
>
> Added to misc-next, thanks. The eventual change to the sysfs file can be
> done later.
>
> How are we going to proceed with the patch from Guilherme?
The last step is to ensure that the temp-fsid feature is restricted
with the temp-fsid superblock flag. Guilherme's patches
(kernel, mkfs, and tune) already handle it but need a rebase.
Can Guilherme send an RFC patch for feedback from others and
copy suggested-by. Because, I haven't found a compelling reason
for the restriction, except to improve the user experience.
His fstests patch will be accepted. And progressively we should
add more coverage when the fstests configuration does not include
the temp-fsid environment.
Lastly, in fact even for this patchset:
Co-developed-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
Thanks, Anand
next prev parent reply other threads:[~2023-10-07 10:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 15:00 [PATCH 0/4] btrfs: sysfs and unsupported temp-fsid features for clones Anand Jain
2023-10-04 15:00 ` [PATCH 1/4] btrfs: comment for temp-fsid, fsid, and metadata_uuid Anand Jain
2023-10-04 15:00 ` [PATCH 2/4] btrfs: disable seed feature for temp-fsid Anand Jain
2023-10-04 15:00 ` [PATCH 3/4] btrfs: disable the device add " Anand Jain
2023-10-04 15:00 ` [PATCH 4/4] btrfs: show temp_fsid feature in sysfs Anand Jain
2023-10-06 14:55 ` David Sterba
2023-10-07 9:12 ` Anand Jain
2023-10-07 9:31 ` Anand Jain
2023-10-06 15:07 ` [PATCH 0/4] btrfs: sysfs and unsupported temp-fsid features for clones David Sterba
2023-10-07 10:30 ` Anand Jain [this message]
2023-10-09 7:00 ` Guilherme G. Piccoli
2023-10-09 8:07 ` Anand Jain
2023-10-09 23:59 ` David Sterba
2023-10-10 1:22 ` Anand Jain
2023-10-18 13:37 ` Guilherme G. Piccoli
2023-10-18 23:04 ` David Sterba
2023-10-19 8:06 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cfb8122-4956-4032-b9ab-2eea8bb19415@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=gpiccoli@igalia.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).