From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64EFFC19F2D for ; Tue, 9 Aug 2022 21:51:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229503AbiHIVvY (ORCPT ); Tue, 9 Aug 2022 17:51:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229703AbiHIVvF (ORCPT ); Tue, 9 Aug 2022 17:51:05 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A9C85C9D7 for ; Tue, 9 Aug 2022 14:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660081857; bh=19qHqzd9omrtML9oe7QnA2icf/AKEYc1SLc2kTxhAY0=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=eXYGJbfJxgr4XM7O+Irq9kbCwxYdFTU4ZQr+Dr7kcWoVcn/8pDwFY0jfFY9PNv8HA Ui8aARBWRIPtwYJHh109Zlp61Y1AjDkpGJzsMfFeT/o15cF0NVcuyXOhhQx3e2LI0l tDRhJoem7aMqCnAqDQYNkwFb8y8ggvVZTg0k0azQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [0.0.0.0] ([149.28.201.231]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MfHAH-1njiH51j3r-00goLO; Tue, 09 Aug 2022 23:50:57 +0200 Message-ID: <9f504e1b-3ee2-9072-51c7-c533c0fb315f@gmx.com> Date: Wed, 10 Aug 2022 05:50:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: misc-next and for-next: kernel BUG at fs/btrfs/extent_io.c:2350! during raid5 recovery Content-Language: en-US To: Zygo Blaxell Cc: linux-btrfs@vger.kernel.org References: From: Qu Wenruo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Eo+CuoEeQuzuG3aQF0FIrn77tTAirZjU8nvTYDYMv3FKPef0MRM IBsFygyfn/4wizAzgfvOmdtvv+PXWNANpoQmYvzFet5pDltG2DOtWOnQZYvBvoKiYvNJiSy 2mgdLQgggJb/O3sg0t1iwYDsd5XtAvYNDZ2xJiOrTS/KHWpPrClgW7kSKPYOzCJ0AKe9q7o 98zUpn7oGQusEZC5lTFOQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:WGJZUMruBXA=:5LqWXwjoEMM8PRvEz7zDrg vuihRC2G31Qp0jzDGTZvKG/b7ffKktMoLq6yOzlyxY09jZAHqFrarS5HfG9qKtmegpctWKv7e ULrgMDGaCEvn4l+tkiM5uB3f93kLNwyoE15NxhyXz1y9SHuzWrtWZ1XJ4Y9pEy9e+GjrDWAnb o4Bq1y6H9hNxtTeYrnaQdhu60xuG1BiXOlP/s7bG0oSghrip0lGqNuUXYcHdT5jVZHGhfcmcn AKweQsUYtKE25bEOIyD4gY0YOsxLm1sYW1nz543GMSZYAN9JV4wnC3M5ZaZxN048Rh4tUDynF y0xAKlnYlcySifYtQ7vApOC9Nd+UoZVGf7oS6hPDlbXiEonLdfctqmVPBfltWZNMQV5F+F5xD QZc8XACd5kEvI1/pmNRU5l0rg6BCtfFoCw8OiHKVnrUHBaKF2qQlj0OKfLEZpAb2RuI1aAHAD XbZqh90WfTeJAGa933kVrxIiUC7EYtQa0UcuucWQ9evaBS3S9T7+rO8NaStFxe/jSHO/buRAr Fbjy5nNan2htrcl31PPtTRotXqc2qAXqBBGEBMXbbLl/RBRhYD6wAw10IpLLNSionsSCfdept DB2tuPQ6AKRRB2aPGnhTOlMl2noEBpCJpHRHm1Bdkaf1kulSWori0g265coNsO92B1d9IKzbZ lEpskxKIPXpPb5z+wqAJfEHyWP4oQWqkh6wAaRRN0DbC42UDrfOOB+/FOmQv8onreD33PtN1p L7WEElg8mQtW8LXjN0sgk2hvyz/Ckl37g7zTPZzdpfVMXw+C8P8i72/nEzWs65VstoZab3JEc psKPcVPtDK/OITNB3azbj647TgAa6Mi0fIeds4pVZ8IlcKEJ6NOvQfspIak9zyQp+5fSWkRgI /JJew1lsde6tdl+lP0Dt6f8/IQiZmHHBgEF50v5XaMexeKRymPWQAQv7tqgK2RnWmz8lbAelg sgnmBX4dWvkTNiWITiwOg3W+S1HqF7sEG80swNb3gsMB1L4e9qHeUh7hlTNou61Bhpqcaj+1Q 1om4MN2FOne3bYix7whV8g2MdUuDMb3tyhyDE9MnVVfiQLi5fSGLdHdqbN+YPuP0EJ4DCCsi9 9ogHdKMwF+Dc+yuao9uCCpOFoBjGVYAtlMmyMJ51tGQI5sQI21DZBufnw== Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 2022/8/10 03:29, Zygo Blaxell wrote: > On Tue, Aug 09, 2022 at 03:35:25PM +0800, Qu Wenruo wrote: >> >> >> On 2022/8/9 11:31, Zygo Blaxell wrote: >>> Test case is: >>> >>> - start with a -draid5 -mraid1 filesystem on 2 disks >>> >>> - run assorted IO with a mix of reads and writes (randomly >>> run rsync, bees, snapshot create/delete, balance, scrub, start >>> replacing one of the disks...) >>> >>> - cat /dev/zero > /dev/vdb (device 1) in the VM guest, or run >>> blkdiscard on the underlying SSD in the VM host, to simulate >>> single-disk data corruption >> >> One thing to mention is, this is going to cause destructive RMW to happ= en. >> >> As currently substripe write will not verify if the on-disk data stripe >> matches its csum. >> >> Thus if the wipeout happens while above workload is still running, it's >> going to corrupt data eventually. > > That would be a btrfs raid5 design bug, That's something all RAID5 design would have the problem, not just btrfs. Any P/Q based profile will have the problem. > since disks don't schedule their > corruptions during idle periods; however, I can modify the test design > to avoid this case (i.e. only corrupt disks while idle or reading). Then it's not much different than this new test case, except the compression part: https://patchwork.kernel.org/project/linux-btrfs/patch/20220727054148.7340= 5-1-wqu@suse.com/ Thanks, Qu > > A BUG_ON is not expected, though, no matter what the disk does. > >> Thanks, >> Qu >>> >>> - repeat until something goes badly wrong, like unrecoverable >>> read error or crash >>> >>> This test case always failed quickly before (corruption was rarely >>> if ever fully repaired on btrfs raid5 data), and it still doesn't work >>> now, but now it doesn't work for a new reason. Progress? >>> >>> There is now a BUG_ON arising from this test case: >>> >>> [ 241.051326][ T45] btrfs_print_data_csum_error: 156 callbacks sup= pressed >>> [ 241.100910][ T45] ------------[ cut here ]------------ >>> [ 241.102531][ T45] kernel BUG at fs/btrfs/extent_io.c:2350! >>> [ 241.103261][ T45] invalid opcode: 0000 [#2] PREEMPT SMP PTI >>> [ 241.104044][ T45] CPU: 2 PID: 45 Comm: kworker/u8:4 Tainted: G = D 5.19.0-466d9d7ea677-for-next+ #85 89955463945a81b56a449b1f= 12383cf0d5e6b898 >>> [ 241.105652][ T45] Hardware name: QEMU Standard PC (i440FX + PIIX= , 1996), BIOS 1.14.0-2 04/01/2014 >>> [ 241.106726][ T45] Workqueue: btrfs-endio-raid56 raid_recover_end= _io_work >>> [ 241.107716][ T45] RIP: 0010:repair_io_failure+0x359/0x4b0 >>> [ 241.108569][ T45] Code: 2b e8 cb 12 79 ff 48 c7 c6 20 23 ac 85 4= 8 c7 c7 00 b9 14 88 e8 d8 e3 72 ff 48 8d bd 48 ff ff ff e8 5c 7e 26 00 e9 = f6 fd ff ff <0f> 0b e8 60 d1 5e 01 85 c0 74 cc 48 c >>> 7 c7 b0 1d 45 88 e8 d0 8e 98 >>> [ 241.111990][ T45] RSP: 0018:ffffbca9009f7a08 EFLAGS: 00010246 >>> [ 241.112911][ T45] RAX: 0000000000000000 RBX: 0000000000000000 RC= X: 0000000000000000 >>> [ 241.115676][ T45] RDX: 0000000000000000 RSI: 0000000000000000 RD= I: 0000000000000000 >>> [ 241.118009][ T45] RBP: ffffbca9009f7b00 R08: 0000000000000000 R0= 9: 0000000000000000 >>> [ 241.119484][ T45] R10: 0000000000000000 R11: 0000000000000000 R1= 2: ffff9cd1b9da4000 >>> [ 241.120717][ T45] R13: 0000000000000000 R14: ffffe60cc81a4200 R1= 5: ffff9cd235b4dfa4 >>> [ 241.122594][ T45] FS: 0000000000000000(0000) GS:ffff9cd2b760000= 0(0000) knlGS:0000000000000000 >>> [ 241.123831][ T45] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050= 033 >>> [ 241.125003][ T45] CR2: 00007fbb76b1a738 CR3: 0000000109c26001 CR= 4: 0000000000170ee0 >>> [ 241.126226][ T45] Call Trace: >>> [ 241.126646][ T45] >>> [ 241.127165][ T45] ? __bio_clone+0x1c0/0x1c0 >>> [ 241.128354][ T45] clean_io_failure+0x21a/0x260 >>> [ 241.128384][ T45] end_compressed_bio_read+0x2a9/0x470 >>> [ 241.128411][ T45] bio_endio+0x361/0x3c0 >>> [ 241.128427][ T45] rbio_orig_end_io+0x127/0x1c0 >>> [ 241.128447][ T45] __raid_recover_end_io+0x405/0x8f0 >>> [ 241.128477][ T45] raid_recover_end_io_work+0x8c/0xb0 >>> [ 241.128494][ T45] process_one_work+0x4e5/0xaa0 >>> [ 241.128528][ T45] worker_thread+0x32e/0x720 >>> [ 241.128541][ T45] ? _raw_spin_unlock_irqrestore+0x7d/0xa0 >>> [ 241.128573][ T45] ? process_one_work+0xaa0/0xaa0 >>> [ 241.128588][ T45] kthread+0x1ab/0x1e0 >>> [ 241.128600][ T45] ? kthread_complete_and_exit+0x40/0x40 >>> [ 241.128628][ T45] ret_from_fork+0x22/0x30 >>> [ 241.128659][ T45] >>> [ 241.128667][ T45] Modules linked in: >>> [ 241.129700][ T45] ---[ end trace 0000000000000000 ]--- >>> [ 241.152310][ T45] RIP: 0010:repair_io_failure+0x359/0x4b0 >>> [ 241.153328][ T45] Code: 2b e8 cb 12 79 ff 48 c7 c6 20 23 ac 85 4= 8 c7 c7 00 b9 14 88 e8 d8 e3 72 ff 48 8d bd 48 ff ff ff e8 5c 7e 26 00 e9 = f6 fd ff ff <0f> 0b e8 60 d1 5e 01 85 c0 74 cc 48 c >>> 7 c7 b0 1d 45 88 e8 d0 8e 98 >>> [ 241.156882][ T45] RSP: 0018:ffffbca902487a08 EFLAGS: 00010246 >>> [ 241.158103][ T45] RAX: 0000000000000000 RBX: 0000000000000000 RC= X: 0000000000000000 >>> [ 241.160072][ T45] RDX: 0000000000000000 RSI: 0000000000000000 RD= I: 0000000000000000 >>> [ 241.161984][ T45] RBP: ffffbca902487b00 R08: 0000000000000000 R0= 9: 0000000000000000 >>> [ 241.164067][ T45] R10: 0000000000000000 R11: 0000000000000000 R1= 2: ffff9cd1b9da4000 >>> [ 241.165979][ T45] R13: 0000000000000000 R14: ffffe60cc7589740 R1= 5: ffff9cd1f45495e4 >>> [ 241.167928][ T45] FS: 0000000000000000(0000) GS:ffff9cd2b760000= 0(0000) knlGS:0000000000000000 >>> [ 241.169978][ T45] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050= 033 >>> [ 241.171649][ T45] CR2: 00007fbb76b1a738 CR3: 0000000109c26001 CR= 4: 0000000000170ee0 >>> >>> KFENCE and UBSAN aren't reporting anything before the BUG_ON. >>> >>> KCSAN complains about a lot of stuff as usual, including several issue= s >>> in the btrfs allocator, but it doesn't look like anything that would >>> mess with a bio. >>> >>> $ git log --no-walk --oneline FETCH_HEAD >>> 6130a25681d4 (kdave/for-next) Merge branch 'for-next-next-v5.20-20220= 804' into for-next-20220804 >>> >>> repair_io_failure at fs/btrfs/extent_io.c:2350 (discriminator 1) >>> 2345 u64 sector; >>> 2346 struct btrfs_io_context *bioc =3D NULL; >>> 2347 int ret =3D 0; >>> 2348 >>> 2349 ASSERT(!(fs_info->sb->s_flags & SB_RDONLY)); >>> >2350< BUG_ON(!mirror_num); >>> 2351 >>> 2352 if (btrfs_repair_one_zone(fs_info, logical)) >>> 2353 return 0; >>> 2354 >>> 2355 map_length =3D length;