From: Mike Fedyk <mfedyk@mikefedyk.com>
To: "Yan, Zheng" <yanzheng@21cn.com>
Cc: liubo <liubo2009@cn.fujitsu.com>,
Linux Btrfs <linux-btrfs@vger.kernel.org>,
Josef Bacik <josef@redhat.com>,
Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Subject: Re: [RFC PATCH 2/4 v2] Btrfs: avoid transaction stuff when readonly
Date: Wed, 1 Dec 2010 21:41:47 -0800 [thread overview]
Message-ID: <AANLkTi=WE5FO6YiW18O9_sVUyhHmQQCjdKEzCSFrMaZh@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=2j4MEJ0s3Ot6+gFP=g3TWVdEsFmhwPKvpTRo-@mail.gmail.com>
On Wed, Dec 1, 2010 at 8:28 PM, Yan, Zheng <yanzheng@21cn.com> wrote:
> On Thu, Dec 2, 2010 at 11:42 AM, liubo <liubo2009@cn.fujitsu.com> wrote:
>> On 12/01/2010 06:20 PM, liubo wrote:
>>> When the filesystem is readonly, avoid transaction stuff by checking MS_RDONLY at
>>> start transaction time.
>>>
>>
>> This patch may lead btrfs panic.
>>
>> Since btrfs allows transaction under readonly fs state, which is a bit weird, btrfs
>> does not even check the returned transaction from start_transaction, although it may
>> return -ENOMEM.
>
> btrfs may do log replay even mount as readonly.
>
What part is logged besides tree roots and/or superblocks?
next prev parent reply other threads:[~2010-12-02 5:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 10:20 [RFC PATCH 2/4 v2] Btrfs: avoid transaction stuff when readonly liubo
2010-12-02 3:42 ` liubo
2010-12-02 4:28 ` Yan, Zheng
2010-12-02 5:38 ` liubo
2010-12-02 5:41 ` Mike Fedyk [this message]
2010-12-02 6:36 ` liubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=WE5FO6YiW18O9_sVUyhHmQQCjdKEzCSFrMaZh@mail.gmail.com' \
--to=mfedyk@mikefedyk.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
--cc=t-itoh@jp.fujitsu.com \
--cc=yanzheng@21cn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).