From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Fedyk Subject: Re: [RFC PATCH 2/4 v2] Btrfs: avoid transaction stuff when readonly Date: Wed, 1 Dec 2010 21:41:47 -0800 Message-ID: References: <4CF62169.8000702@cn.fujitsu.com> <4CF7158C.30801@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: liubo , Linux Btrfs , Josef Bacik , Tsutomu Itoh To: "Yan, Zheng" Return-path: In-Reply-To: List-ID: On Wed, Dec 1, 2010 at 8:28 PM, Yan, Zheng wrote: > On Thu, Dec 2, 2010 at 11:42 AM, liubo wrote: >> On 12/01/2010 06:20 PM, liubo wrote: >>> When the filesystem is readonly, avoid transaction stuff by checking MS_RDONLY at >>> start transaction time. >>> >> >> This patch may lead btrfs panic. >> >> Since btrfs allows transaction under readonly fs state, which is a bit weird, btrfs >> does not even check the returned transaction from start_transaction, although it may >> return -ENOMEM. > > btrfs may do log replay even mount as readonly. > What part is logged besides tree roots and/or superblocks?