linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Nicol <davidnicol@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: linux-btrfs@vger.kernel.org
Subject: Re: IOCTL #21 part two: btrfs progs patch, including iso 8601 timeout support
Date: Thu, 7 Oct 2010 10:50:30 -0500	[thread overview]
Message-ID: <AANLkTikApZDmSDKw6+yFs9Ahvn5XX0ULwE6Of+FkN872@mail.gmail.com> (raw)
In-Reply-To: <AANLkTine=HRxuXFZ4e44UMsAs+j4XmZj9h4n_eZYegNg@mail.gmail.com>

On Thu, Oct 7, 2010 at 9:25 AM, David Nicol <davidnicol@gmail.com> wrot=
e:
> anyway I think I got the logic wrong: the function as given yesterday
> would misparse
>
> =C2=A0 PT1M1M

no it wouldn't! because of the post-increment on the how-to-parse 'M'
state variable, the BIGM label can only get jumped to the first time,
and not following T, W, D or H. Rearranging it to have a forward jump
would lose this.

Better to have an initial sanity-check pass to verify that all
non-numerics are expected and in an acceptable order, and switch one
of the kinds of Ms to some other letter at that time, then zip through
the pieces with a case statement with no logic in it at all, just
stacked multiplications.

Goffredo -- this thinking-out-loud is not noise?
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-10-07 15:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06 21:00 IOCTL #21 part two: btrfs progs patch, including iso 8601 timeout support David Nicol
2010-10-07  6:10 ` Goffredo Baroncelli
2010-10-07 13:50   ` David Nicol
2010-10-07 14:25     ` David Nicol
2010-10-07 15:50       ` David Nicol [this message]
2010-10-07 17:38   ` David Nicol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikApZDmSDKw6+yFs9Ahvn5XX0ULwE6Of+FkN872@mail.gmail.com \
    --to=davidnicol@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).