From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mitch Harder Subject: Re: [PATCH] btrfs file write debugging patch Date: Mon, 7 Mar 2011 00:07:58 -0600 Message-ID: References: <1865303E0DED764181A9D882DEF65FB68662CD02C8@shsmsx502.ccr.corp.intel.com> <1299203447-sup-9359@think> <1299241124-sup-3502@think> <1299434330-sup-8189@think> <1299459296-sup-3057@think> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Xin Zhong , "xin.zhong" , linux-btrfs To: Chris Mason Return-path: In-Reply-To: <1299459296-sup-3057@think> List-ID: On Sun, Mar 6, 2011 at 6:58 PM, Chris Mason wr= ote: > Excerpts from Chris Mason's message of 2011-03-06 13:00:27 -0500: >> Excerpts from Mitch Harder's message of 2011-03-05 11:50:14 -0500: >> > I've constructed a test patch that is currently addressing all the >> > issues on my system. >> > >> > The portion of Openmotif that was having issues with page faults w= orks >> > correctly with this patch, and gcc-4.4.5 builds without issue. >> > >> > I extracted only the portion of the first patch that corrects the >> > handling of dirty_pages when copied=3D=3D0, and incorporated the s= econd >> > patch that falls back to one-page-at-a-time if there are troubles = with >> > page faults. >> >> Just to make sure I understand, could you please post the full combi= ned >> path that was giving you trouble with gcc? =A0We do need to make sur= e the >> pages are properly up to date if we fall back to partial writes. > > Ok, I was able to reproduce this easily with fsx. =A0The problem is t= hat I > wasn't making sure the last partial page in the write was up to date > when it was also the first page in the write. > > Here is the updated patch, it has all the fixes we've found so far: > This latest patch that Chris has sent out fixes the issues I've been encountering. I can build gcc-4.4.5 without problems. Also, the portion of Openmotif that was having issues with page faults is working correctly. Let me know if you still would like to see the path names for the portions of the gcc-4.4.5 build that were giving me issues. I didn't save that information, but I can regenerate it. But it sounds like it's irrelevant now. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html