From: Zhu Yanhai <zhu.yanhai@gmail.com>
To: "André Nogueira" <andre.neo.net@gmail.com>
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Function btree_get_extent: Incorrect if-else if statement
Date: Mon, 6 Sep 2010 22:15:02 +0800 [thread overview]
Message-ID: <AANLkTimXO7td7xxD1_MVACjbKomE0VBLLV7A1U0z00eR@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimCtN1hten5v+tdwG9yiKsFmSMPcQU-eLefDQkc@mail.gmail.com>
This is not correct.
2010/8/9 Andr=C3=A9 Nogueira <andre.neo.net@gmail.com>:
> The btree_get_extent function (in file disk-io.c) calls the
> add_extent_mapping (in file extent_map.c). The add_extent_mapping
> function can return two values: 0 or -EEXIST.
It might return some other error values besides -EEXIST, the 'else if
(ret)' branch
is just against them.
Namely, we should do some thing special when EEXIST, and do another thi=
ngs
for all other errors.
Regards,
Zhu Yanhai
prev parent reply other threads:[~2010-09-06 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 10:47 [PATCH] Function btree_get_extent: Incorrect if-else if statement André Nogueira
2010-09-06 13:51 ` Andre Nogueira
2010-09-06 14:15 ` Zhu Yanhai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimXO7td7xxD1_MVACjbKomE0VBLLV7A1U0z00eR@mail.gmail.com \
--to=zhu.yanhai@gmail.com \
--cc=andre.neo.net@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).