From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Berry Subject: Re: Updating the wiki pages adding btrfs command [Was Re: reserving an IOCTL number; other details] Date: Wed, 15 Sep 2010 11:41:30 -0700 Message-ID: References: <201009131923.53227.kreijack@libero.it> <201009142125.56710.kreijack@libero.it> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: kreijack , linux-btrfs To: David Nicol Return-path: In-Reply-To: List-ID: On Wed, Sep 15, 2010 at 07:10, David Nicol wrote: > Does the manpatch below describe an acceptable API for a hook to a > facility for waiting for the completion of deleted snapshot cleanup? ... > +\fBfilesystem GC\fR\fI [ms] \fR > +wait for completion of salvage of deleted subvolumes on > +the filesystem identified by \fI\fR. The optional > +timeout is in milliseconds. > +.TP I'd suggest different wording for the manpage: filesystem GC [timeout_in_ms] Wait for btrfs to free any space that was used by deleted subvolumes in . If timeout_in_ms is specified, wait up to that many milliseconds, then exit with status 1 [or whatever code is chosen] if not all space could be freed in that time. Personally, I like "gc" or "clean". "wait-subvolume-deletion", "garbage-collect" or similar is too verbose for my taste. -- Josh