From: Zhang JieJing <kzjeef@gmail.com>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: handle kmalloc() failure in btrfs_file_aio_write()
Date: Sun, 20 Jun 2010 12:56:02 +0800 [thread overview]
Message-ID: <AANLkTinv_7JGRhI8PtnmPUY3yqcPJBV7-ENPsCfYJPkb@mail.gmail.com> (raw)
In-Reply-To: <1276971194-24572-1-git-send-email-kzjeef@gmail.com>
2010/6/20 JieJing.Zhang <kzjeef@gmail.com>
>
> set errno to -ENOMEM and goto out
>
> Signed-off-by: JieJing.Zhang <kzjeef@gmail.com>
> ---
> =A0fs/btrfs/file.c | =A0 =A04 ++++
> =A01 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
> index e354c33..e0fcb6c 100644
> --- a/fs/btrfs/file.c
> +++ b/fs/btrfs/file.c
> @@ -926,6 +926,10 @@ static ssize_t btrfs_file_aio_write(struct kiocb=
*iocb,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 PAGE_CACHE_SIZE, PAGE_CACHE_S=
IZE /
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (sizeof(struct page *)));
> =A0 =A0 =A0 =A0pages =3D kmalloc(nrptrs * sizeof(struct page *), GFP_=
KERNEL);
I think this gfp should changed to GFP_NOFS to avoid deadlock, right ?
like this commit: 33818bbb84cd371b63ed8849cc5264d24c8b3aa2
> + =A0 =A0 =A0 if (!pages) {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 ret =3D -ENOMEM;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto out;
> + =A0 =A0 =A0 }
>
> =A0 =A0 =A0 =A0/* generic_write_checks can change our pos */
> =A0 =A0 =A0 =A0start_pos =3D pos;
> --
> 1.7.0.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-06-20 4:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-19 18:13 [PATCH] Btrfs: handle kmalloc() failure in btrfs_file_aio_write() JieJing.Zhang
2010-06-20 4:56 ` Zhang JieJing [this message]
2010-07-03 17:35 ` Zhang JieJing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinv_7JGRhI8PtnmPUY3yqcPJBV7-ENPsCfYJPkb@mail.gmail.com \
--to=kzjeef@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).