From: Mitch Harder <mitch.harder@sabayonlinux.org>
To: dave@jikos.cz, Stephen Rothwell <sfr@canb.auug.org.au>,
Chris Mason <chris.mason@oracle.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: linux-next: build warninga in Linus' tree
Date: Wed, 1 Jun 2011 10:16:48 -0500 [thread overview]
Message-ID: <BANLkTi=t5H8sAc_0sHyFt_xJgbeVibO3KQ@mail.gmail.com> (raw)
In-Reply-To: <20110531175709.GC12709@twin.jikos.cz>
On Tue, May 31, 2011 at 12:57 PM, David Sterba <dave@jikos.cz> wrote:
> Hi,
>
> On Mon, May 30, 2011 at 11:36:53AM +1000, Stephen Rothwell wrote:
>> After merging the Linus' tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced these warnings:
>>
>> fs/btrfs/sysfs.c:76:26: warning: 'btrfs_root_attrs' defined but not used
>> fs/btrfs/sysfs.c:97:26: warning: 'btrfs_super_attrs' defined but not used
>> fs/btrfs/sysfs.c:153:13: warning: 'btrfs_super_release' defined but not used
>> fs/btrfs/sysfs.c:160:13: warning: 'btrfs_root_release' defined but not used
>>
>> I have started using gcc v4.5.2 (instead of v4.4.4) if that makes a
>> difference.
>
> the warning probably started to show up after one of my cleanup patches,
> removing unused functions (f2a97a9dbd86eb1ef956bdf20e05c507b32beb96).
> The sysfs interface is not being used right now, but there's a unmerged
> patchset which adds the interesting bits like info about available btrfs
> filesystems and devices. I don't know what are the intentions regarding
> sysfs.
>
>
> david
I've been playing around with resurrecting the basic sysfs
capabilities that had been previously incorporated into btrfs.
As it stands right now, it was relatively easy to re-implement sysfs
as it was originally. However, that implementation of sysfs wasn't
populated with much information (only total_blocks, blocks_used, and
blocksize).
I also had to reverse a small portion of code that was in the last clean-up.
If a CONFIG_BTRFS_DEBUG type configuration flag is ever introduced, it
would be interesting to resurrect btrfs' sysfs capabilities.
next prev parent reply other threads:[~2011-06-01 15:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 1:36 linux-next: build warninga in Linus' tree Stephen Rothwell
2011-05-31 17:57 ` David Sterba
2011-06-01 15:16 ` Mitch Harder [this message]
2011-06-03 11:10 ` David Sterba
2011-06-03 11:38 ` Hugo Mills
2011-06-03 13:16 ` Greg KH
2011-06-03 13:16 ` Greg KH
2011-06-03 12:25 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=t5H8sAc_0sHyFt_xJgbeVibO3KQ@mail.gmail.com' \
--to=mitch.harder@sabayonlinux.org \
--cc=chris.mason@oracle.com \
--cc=dave@jikos.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).