From: Joe Peterson <lavajoe@gentoo.org>
To: linux-btrfs@vger.kernel.org
Subject: Fix to btrfs-progs to avoid "underlinking"
Date: Sun, 5 Jun 2011 10:41:15 -0600 [thread overview]
Message-ID: <BANLkTikPLUU=3bG0-S9X9a5oDQsKCD9E5Q@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
Attached is a simple patch to the makefile line that builds "convert".
It explicitly includes libcom_err, which is implicitly pulled in by
libext2fs. This fixes a what is called "underlinking" in this blog
post:
http://blog.flameeyes.eu/2010/11/26/it-s-not-all-gold-that-shines-why-underlinking-is-a-bad-thing
Apparently, this condition causes links to fail using the "gold link
editor", and it can cause future library version incompatibilities to
not be detected (so that affected programs can be rebuilt).
-Joe
[Note: please CC my email address in any responses]
[-- Attachment #2: btrfs-progs-0.19-fix-underlinking.patch --]
[-- Type: text/x-patch, Size: 579 bytes --]
--- btrfs-progs-0.19/Makefile~ 2011-06-05 10:21:04.000000000 -0600
+++ btrfs-progs-0.19/Makefile 2011-06-05 10:21:46.000000000 -0600
@@ -75,7 +75,7 @@ quick-test: $(objects) quick-test.o
gcc $(CFLAGS) -o quick-test $(objects) quick-test.o $(LDFLAGS) $(LIBS)
convert: $(objects) convert.o
- gcc $(CFLAGS) -o btrfs-convert $(objects) convert.o -lext2fs $(LDFLAGS) $(LIBS)
+ gcc $(CFLAGS) -o btrfs-convert $(objects) convert.o -lext2fs -lcom_err $(LDFLAGS) $(LIBS)
ioctl-test: $(objects) ioctl-test.o
gcc $(CFLAGS) -o ioctl-test $(objects) ioctl-test.o $(LDFLAGS) $(LIBS)
reply other threads:[~2011-06-05 16:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikPLUU=3bG0-S9X9a5oDQsKCD9E5Q@mail.gmail.com' \
--to=lavajoe@gentoo.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).