From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FCDCC433E1 for ; Tue, 28 Jul 2020 01:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 472A720714 for ; Tue, 28 Jul 2020 01:58:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=dxuuu.xyz header.i=@dxuuu.xyz header.b="eXqncfmL"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="o/Z3A2dr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726769AbgG1B6X (ORCPT ); Mon, 27 Jul 2020 21:58:23 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:38561 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726278AbgG1B6V (ORCPT ); Mon, 27 Jul 2020 21:58:21 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 761BA5C005E; Mon, 27 Jul 2020 21:58:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 27 Jul 2020 21:58:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dxuuu.xyz; h= content-transfer-encoding:content-type:to:cc:subject:from:date :message-id:in-reply-to; s=fm1; bh=Nc2nupnSfk1A8BrW0HSbGcKbqGtZ7 WNkRowoAM3KIxs=; b=eXqncfmLtqPEvWnzkGQVxEZ6XK8qZHE7wLj+oaSZw52PE j9ggJXobNbO4KatRMOvYa8kodH3urfaMLXvJcBabXR0GeXE/Yt3lDz7joEzs75/Q akIU91aoklqPBzoP9RmS16I0/WgiDg4ETNgzGWCtN0LpECMkJXq1ZDUJl91Dtu46 IFxycvbSyDYWYMWmYa1oZRTxhiceWTuiebmBrgnz7+Z4SOOht0J54gKU/59ce5S8 5DkFq85xH3QINbrup1xAIndIy68jMGoZtRzMdldfC7U65+sWuBkMNr/LXGEoSZRx uvrTX5gj/sRlJoYasJ5ZIX8uv0qel28nowCVTXOzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Nc2nup nSfk1A8BrW0HSbGcKbqGtZ7WNkRowoAM3KIxs=; b=o/Z3A2drvNl/6Oiz5zWszQ mQ0xUnqukcHEwuNCIRA1EzuplIpb2fd+WcxRiq+XSEd5ZEp8/xLU2z0Pcmt59AZs n5PtCNsjrYS46kEZtGIsczZqTS8GxhQR9zvQPxZpqdn4ESx4mpvnv1tGKFba53QZ oiwv61MMMrk6SgsGzs/LjE1NcXhcVY8iaOHjEPdyxiorA240FZusbN+jjVBbL6ZZ KxqzRTIiYe8FIfAEnC/5HS+x/1YKPKlWLQBBqJtmtZVngajPl/uQwx9ZhpgyB5UR vURMsX48q2pT/Fgtl1T7Gok1n775494VZ+jfFenV86g46jnXSnal9HtJczQym34g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedriedugdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculddvfedmnecujfgurhepgfgtvf fuhfffkfgjsehtqhertddttdejnecuhfhrohhmpedfffgrnhhivghlucgiuhdfuceougig uhesugiguhhuuhdrgiihiieqnecuggftrfgrthhtvghrnhepkedujeekteeufefggeehfe fhkeehueekfedtleekffektdeugefhveffjeehgedtnecuffhomhgrihhnpegvughithho rhgtohhnfhhighdrohhrghenucfkphepjeefrdelfedrvdegjedrudefgeenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegugihusegugihuuhhu rdighiii X-ME-Proxy: Received: from localhost (c-73-93-247-134.hsd1.ca.comcast.net [73.93.247.134]) by mail.messagingengine.com (Postfix) with ESMTPA id E0B7E30600B2; Mon, 27 Jul 2020 21:58:19 -0400 (EDT) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 To: "Qu Wenruo" , Cc: Subject: Re: [PATCH] btrfs-progs: Add basic .editorconfig From: "Daniel Xu" Date: Mon, 27 Jul 2020 18:57:49 -0700 Message-Id: In-Reply-To: <349343e3-8687-d217-66f8-59d50e8a8ced@gmx.com> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon Jul 27, 2020 at 6:57 PM PDT, Qu Wenruo wrote: > > > On 2020/7/28 =E4=B8=8A=E5=8D=889:50, Qu Wenruo wrote: > >=20 > >=20 > > On 2020/7/28 =E4=B8=8A=E5=8D=889:24, Daniel Xu wrote: > >> Not all contributors work on projects that use linux kernel coding > >> style. This commit adds a basic editorconfig [0] to assist contributor= s > >> with managing configuration. > >> > >> [0]: https://editorconfig.org/ > >=20 > > I like the idea of the generic style file. > > It's just one single file for all editors. > >=20 > > Although most btrfs developers I know use vim, and it's not supported > > natively, it shouldn't be a big problem, a plugin would handle it > > without problem. > >=20 > >> > >> Signed-off-by: Daniel Xu > >=20 > > Reviewed-by: Qu Wenruo > >=20 > > But a small nitpick inlined below. > >=20 > >> --- > >> .editorconfig | 10 ++++++++++ > >> .gitignore | 1 + > >> 2 files changed, 11 insertions(+) > >> create mode 100644 .editorconfig > >> > >> diff --git a/.editorconfig b/.editorconfig > >> new file mode 100644 > >> index 00000000..2829cfbe > >> --- /dev/null > >> +++ b/.editorconfig > >> @@ -0,0 +1,10 @@ > >> +[*] > >> +end_of_line =3D lf > >> +insert_final_newline =3D true > >> +trim_trailing_whitespace =3D true > >> +charset =3D utf-8 > >> +indent_style =3D space > > Wait for a minute, does that mean, we use space as indent? > IIRC kernel code style goes tab if possible? > > Thanks, > Qu Sorry, that was mistake. Just sent out a V2 before I saw your email. Thanks, Daniel