Re: [PATCH 3/3] btrfs-progs: add TLS arguments to send/receive

[Sheng Mao <shngmao@gmail.com>]

Hi Yugui,

Thank you for the feedback!

1. Yes, we can do that. The reason why I use —tls-addr on both sides is to introduce least vocabulary for users.
2. I don’t have a 10Gpbs NIC to have a thorough benchmark on TLS vs raw sockets. The flame graph shows 
decrypt_skb_update (related to TLS decoding) takes about 3.5% of CPU time for my 1Gbps setup. The transfer 
saturates the bandwidth. Do you have any 10Gbps devices? Would you mind to help me benchmarking after 
introducing —tls-mode none?

Thank you! Happy new year!

Regards,
Sheng

> On Dec 31, 2020, at 04:16, Wang Yugui <wangyugui@e16-tech.com> wrote:
> 
> Hi, Sheng Mao
> 
> some feedback.
> 
> 1, can we use 'listen-addr' for sever side, and 'conn-addr' for client
> side?
> 
> 2, can we support '--tls-mode none' for tcp without TLS, 
> and then change 'tls-port' to 'tcp-port'? 
> 
> Is there some boost performance for tcp without TLS too?
> 
> 
>> +--tls-addr <url>::
>> +Address to listen on. It can be an IP address or a domain name.
>> +
>> +--tls-port <port>::
>> +The local port of the TLS connection.
>> +
>> +--tls-key <file>::
>> +Use the key from file; otherwise read key from stdin. Key file is first parsed
>> +as PEM format; if parsing fails, file content is treated as binary key.
>> +
>> +--tls-mode <mode>::
>> +Use tls_12_128_gcm, tls_13_128_gcm, tls_12_256_gcm.
> 
> Best Regards
> Wang Yugui (wangyugui@e16-tech.com)
> 2020/12/31
> 
>