From: Zhihui Zhang <zzhsuny@gmail.com>
To: dsterba@suse.cz, Zhihui Zhang <zzhsuny@gmail.com>,
jbacik@fb.com, dsterba@suse.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: make sure there is always room for generation number
Date: Thu, 5 Jul 2018 08:40:09 -0400 [thread overview]
Message-ID: <CADFvMYL9Bb1DZp15n2H2WFKvQKDbsoU82DysP5sXOp9_o3-q-Q@mail.gmail.com> (raw)
In-Reply-To: <20180704152136.GV3126@twin.jikos.cz>
code inspection. If I understand it correctly, we are off by 4 bytes
because CRC is 32 bits and generation is 64 bits. But this bug might
never hit in practice.
thanks,
-Zhihui
On Wed, Jul 4, 2018 at 11:21 AM, David Sterba <dsterba@suse.cz> wrote:
> On Mon, Jul 02, 2018 at 08:00:54PM -0400, Zhihui Zhang wrote:
>> io_ctl_set_generation() assumes that the generation number shares
>> the same page with inline CRCs. Let's make sure this is always true.
>>
>> Signed-off-by: Zhihui Zhang <zzhsuny@gmail.com>
>
> Reviewed-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2018-07-05 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 0:00 [PATCH] Btrfs: make sure there is always room for generation number Zhihui Zhang
2018-07-04 15:14 ` David Sterba
2018-07-04 15:21 ` David Sterba
2018-07-05 12:40 ` Zhihui Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADFvMYL9Bb1DZp15n2H2WFKvQKDbsoU82DysP5sXOp9_o3-q-Q@mail.gmail.com \
--to=zzhsuny@gmail.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).