* Is it safe to refactor struct btrfs_root *root out of these functions?
@ 2014-11-11 13:29 Daniel Dressler
0 siblings, 0 replies; only message in thread
From: Daniel Dressler @ 2014-11-11 13:29 UTC (permalink / raw)
To: linux-btrfs
Hi
I'm gearing up to tackle the "Pass fs_info instead of root " project
suggested on the wiki.
I've read through the entire codebase and made note of 102 functions
which could be refactored. Three of these do not make any use of their
root argument at all, is it safe to refactor these as well?
Namely:
btrfs_block_rsv_check :
http://lxr.free-electrons.com/source/fs/btrfs/extent-tree.c#L4743
copy_to_sk : http://lxr.free-electrons.com/source/fs/btrfs/ioctl.c#L1931
wait_for_commit :
http://lxr.free-electrons.com/source/fs/btrfs/transaction.c#L597
None of these function's users make indirect calls through function
pointers. Is it safe to refactor them? I ask because it seems strange
they would have unused arguments and I'm worried there might be a
reason I've missed.
Daniel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-11-11 13:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-11 13:29 Is it safe to refactor struct btrfs_root *root out of these functions? Daniel Dressler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).