linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Murphy <lists@colorremedies.com>
To: Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: /etc/fstab rootfs options vs grub2 rootflags cmdline
Date: Wed, 4 May 2016 11:58:28 -0600	[thread overview]
Message-ID: <CAJCQCtSg7f_U2bJ8UpbEDJwn2d2GGJFKx5yss2tOWS-AdWGJfw@mail.gmail.com> (raw)
In-Reply-To: <pan$7b1b$2e968d2f$7ddc7045$1ba7386@cox.net>

> Niccolò Belli posted on Wed, 04 May 2016 11:46:10 +0200 as excerpted:
>
>> Hi,
>> I have the following options for my rootfs in /etc/fstab:
>> rw,relatime,compress=lzo,ssd,discard,space_cache,autodefrag,
>> subvolid=257,subvol=/@

The combination of subvolid and subvol is rejected in recent kernels.
I don't know if it's rejected only if they point to different fs
trees, or if it's always rejected to have both. In any case, both does
not make sense. Pick one.




>>
>> grub2 already placed rootflags=subvol=@ in its cmdline, but not the
>> other options.

Separate them with a comma, it's valid just as it is in fstab. All you
appear to need are:

rootflags=autodefrag,discard,compress=lzo,subvolid=257

ssd should be automatically detected unless the volume is on dmcrypt
or lvm or raid. rw, relatime, space_cache are defaults. Discard is
only advised if your SSD supports queued trim, otherwise you should
rely on the systemd fstrim.timer service being enabled instead.
Everything else in your fstab is already the default.






-- 
Chris Murphy

      parent reply	other threads:[~2016-05-04 17:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04  9:46 /etc/fstab rootfs options vs grub2 rootflags cmdline Niccolò Belli
2016-05-04 11:40 ` Duncan
2016-05-04 13:52   ` Niccolò Belli
2016-05-04 15:54     ` Duncan
2016-05-04 16:31       ` Andrei Borzenkov
2016-05-04 18:07     ` Chris Murphy
2016-05-04 18:34       ` Duncan
2016-05-04 19:28         ` Chris Murphy
2016-05-04 18:56       ` Austin S. Hemmelgarn
2016-05-04 17:58   ` Chris Murphy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJCQCtSg7f_U2bJ8UpbEDJwn2d2GGJFKx5yss2tOWS-AdWGJfw@mail.gmail.com \
    --to=lists@colorremedies.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).