From: Chris Murphy <lists@colorremedies.com>
To: Marek Behun <marek.behun@nic.cz>
Cc: Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: when does btrfs create sparse extents?
Date: Wed, 22 Apr 2020 14:26:31 -0600 [thread overview]
Message-ID: <CAJCQCtTDGb1hAAdp1-ph0wzFcfQNyAh-+hNMipdRmK0iTZA8Xw@mail.gmail.com> (raw)
In-Reply-To: <20200422205209.0e2efd53@nic.cz>
On Wed, Apr 22, 2020 at 12:52 PM Marek Behun <marek.behun@nic.cz> wrote:
>
> Hello,
>
> there was a bug fixed recently in U-Boot's btrfs driver - the driver
> failed to read files with sparse extents. This causes that sometimes
> device failes to boot Linux, since the kernel fails to load from
> storage.
>
> So when does kernel's btrfs driver write sparse extents? Is it always
> when it finds a PAGE_SIZEd and aligned all-zeros block? Or is it more
> complicated?
I'm not a btrfs developer, so with respect to kernel code behavior I
can't answer directly.
But I wonder if other sources of this sparseness has been considered?
Maybe the build system is creating or preserving sparseness? e.g. `tar
--hole-detection` or `--sparse` is used.
Another possibility is Btrfs supports two kinds of holes in the
on-disk format for sparse files. Maybe uboot only supported the
original (current default) type, and the bug really fixed the newer
'no-holes' feature version?
--
Chris Murphy
next prev parent reply other threads:[~2020-04-22 20:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 18:52 when does btrfs create sparse extents? Marek Behun
2020-04-22 20:26 ` Chris Murphy [this message]
2020-04-22 20:44 ` Marek Behun
2020-04-22 20:44 ` Chris Murphy
2020-04-22 20:58 ` Marek Behun
2020-04-22 21:05 ` Chris Murphy
2020-04-23 10:49 ` Filipe Manana
2020-04-23 11:42 ` Marek Behun
2020-04-23 11:51 ` Filipe Manana
2020-04-23 12:05 ` Marek Behun
2020-04-23 12:39 ` Filipe Manana
2020-04-23 19:50 ` Chris Murphy
2020-04-23 5:57 ` Andrei Borzenkov
2020-04-23 6:45 ` Marek Behun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJCQCtTDGb1hAAdp1-ph0wzFcfQNyAh-+hNMipdRmK0iTZA8Xw@mail.gmail.com \
--to=lists@colorremedies.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marek.behun@nic.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).