From: Namjae Jeon <linkinjeon@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: bfields@fieldses.org, akpm@linux-foundation.org,
viro@zeniv.linux.org.uk, chris.mason@fusionio.com,
sage@inktank.com, miklos@szeredi.hu,
konishi.ryusuke@lab.ntt.co.jp, mfasheh@suse.com,
jlbec@ejvilplan.org, jack@suse.cz, bpm@sgi.com, elder@kernel.org,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-nilfs@vger.kernel.org, reiserfs-devel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Namjae Jeon <namjae.jeon@samsung.com>,
Vivek Trivedi <t.vivek@samsung.com>
Subject: Re: [PATCH] fs: encode_fh: return FILEID_INVALID if invalid fid_type
Date: Tue, 12 Feb 2013 07:24:59 +0900 [thread overview]
Message-ID: <CAKYAXd8rPwaxe5wzeJ7RfCkkCV22H2FDHzJb4c_D2Qro4eJhXQ@mail.gmail.com> (raw)
In-Reply-To: <20130211213311.GE8257@dastard>
2013/2/12, Dave Chinner <david@fromorbit.com>:
> On Mon, Feb 11, 2013 at 05:25:58PM +0900, Namjae Jeon wrote:
>> From: Namjae Jeon <namjae.jeon@samsung.com>
>>
>> This patch is a follow up on below patch:
>>
>> [PATCH] exportfs: add FILEID_INVALID to indicate invalid fid_type
>> commit: 216b6cbdcbd86b1db0754d58886b466ae31f5a63
> ....
>> diff --git a/fs/xfs/xfs_export.c b/fs/xfs/xfs_export.c
>> index a836118..3391800 100644
>> --- a/fs/xfs/xfs_export.c
>> +++ b/fs/xfs/xfs_export.c
>> @@ -48,7 +48,7 @@ static int xfs_fileid_length(int fileid_type)
>> case FILEID_INO32_GEN_PARENT | XFS_FILEID_TYPE_64FLAG:
>> return 6;
>> }
>> - return 255; /* invalid */
>> + return FILEID_INVALID; /* invalid */
>> }
>
> I think you can drop the "/* invalid */" comment from there now as
> it is redundant with this change.
Okay, Thanks for review :-)
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
>
next prev parent reply other threads:[~2013-02-11 22:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 8:25 [PATCH] fs: encode_fh: return FILEID_INVALID if invalid fid_type Namjae Jeon
2013-02-11 13:39 ` Sage Weil
2013-02-11 21:33 ` Dave Chinner
2013-02-11 22:24 ` Namjae Jeon [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-31 16:46 Namjae Jeon
2012-09-05 11:22 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKYAXd8rPwaxe5wzeJ7RfCkkCV22H2FDHzJb4c_D2Qro4eJhXQ@mail.gmail.com \
--to=linkinjeon@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=bpm@sgi.com \
--cc=ceph-devel@vger.kernel.org \
--cc=chris.mason@fusionio.com \
--cc=david@fromorbit.com \
--cc=elder@kernel.org \
--cc=jack@suse.cz \
--cc=jlbec@ejvilplan.org \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=miklos@szeredi.hu \
--cc=namjae.jeon@samsung.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=sage@inktank.com \
--cc=t.vivek@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).