From: Mitch Harder <mitch.harder@sabayonlinux.org>
To: Chris Mason <chris.mason@fusionio.com>,
Liu Bo <bo.li.liu@oracle.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"mitch.harder@sabayonlinux.org" <mitch.harder@sabayonlinux.org>,
"dsterba@suse.cz" <dsterba@suse.cz>
Subject: Re: [PATCH v2] Btrfs: fix race between snapshot deletion and getting inode
Date: Wed, 30 Jan 2013 09:09:19 -0600 [thread overview]
Message-ID: <CAKcLGm8=D7U_UW55dRCc8NukEivS2VJMWON+izPPtquNyxofvA@mail.gmail.com> (raw)
In-Reply-To: <20130129035216.GC23893@shiny.globalsuite.net>
On Mon, Jan 28, 2013 at 9:52 PM, Chris Mason <chris.mason@fusionio.com> wrote:
> On Mon, Jan 28, 2013 at 08:22:10PM -0700, Liu Bo wrote:
>> While running snapshot testscript created by Mitch and David,
>> the race between autodefrag and snapshot deletion can lead to
>> corruption of dead_root list so that we can get crash on
>> btrfs_clean_old_snapshots().
>
> Really nice. Thanks to everyone that hashed this out.
>
> -chris
I've been testing "[PATCH v2] Btrfs: fix race between snapshot
deletion and getting inode" along with "[PATCH v6] Btrfs:
snapshot-aware defrag" using the same work flow that was reproducing
the dead_root list corruptions.
I've been unable to reproduce the error in ~24 hours of testing.
Normally, I'd hit the error within an hour of testing on a single run.
I've made three separate runs, and let the last run proceed
overnight.
I'll keep using these patches, and let you know if anything turns up.
Thanks for all your work on this patch set.
prev parent reply other threads:[~2013-01-30 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 3:22 [PATCH v2] Btrfs: fix race between snapshot deletion and getting inode Liu Bo
2013-01-29 3:52 ` Chris Mason
2013-01-30 15:09 ` Mitch Harder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKcLGm8=D7U_UW55dRCc8NukEivS2VJMWON+izPPtquNyxofvA@mail.gmail.com' \
--to=mitch.harder@sabayonlinux.org \
--cc=bo.li.liu@oracle.com \
--cc=chris.mason@fusionio.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).