From: Filipe Manana <fdmanana@kernel.org>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs: remove gfp_t flag from btrfs_tree_mod_log_insert_key()
Date: Fri, 14 Oct 2022 14:47:32 +0100 [thread overview]
Message-ID: <CAL3q7H4MWu6UuhcAbko51PuuV5ta6XP6V4Q_FBQuJybLM1vE7w@mail.gmail.com> (raw)
In-Reply-To: <20221014133011.GH13389@twin.jikos.cz>
On Fri, Oct 14, 2022 at 2:30 PM David Sterba <dsterba@suse.cz> wrote:
>
> On Thu, Oct 13, 2022 at 11:36:26AM +0100, fdmanana@kernel.org wrote:
> >index 8a3a14686d3e..6606534fc36a 100644
> > --- a/fs/btrfs/tree-mod-log.c
> > +++ b/fs/btrfs/tree-mod-log.c
> > @@ -220,7 +220,7 @@ static struct tree_mod_elem *alloc_tree_mod_elem(struct extent_buffer *eb,
> > }
> >
> > int btrfs_tree_mod_log_insert_key(struct extent_buffer *eb, int slot,
> > - enum btrfs_mod_log_op op, gfp_t flags)
> > + enum btrfs_mod_log_op op)
> > {
> > struct tree_mod_elem *tm;
> > int ret;
> > @@ -228,7 +228,7 @@ int btrfs_tree_mod_log_insert_key(struct extent_buffer *eb, int slot,
> > if (!tree_mod_need_log(eb->fs_info, eb))
> > return 0;
> >
> > - tm = alloc_tree_mod_elem(eb, slot, op, flags);
> > + tm = alloc_tree_mod_elem(eb, slot, op, GFP_NOFS);
>
> And after that alloc_tree_mod_elem is also called only with GFP_NOFS.
Indeed.
Just sent a v2 with that change as well.
Thanks.
>
> > if (!tm)
> > return -ENOMEM;
> >
next prev parent reply other threads:[~2022-10-14 13:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 10:36 [PATCH 0/2] btrfs: drop no longer needed atomic allocation for tree mod log operations fdmanana
2022-10-13 10:36 ` [PATCH 1/2] btrfs: switch GFP_ATOMIC to GFP_NOFS when fixing up low keys fdmanana
2022-10-13 10:36 ` [PATCH 2/2] btrfs: remove gfp_t flag from btrfs_tree_mod_log_insert_key() fdmanana
2022-10-14 13:30 ` David Sterba
2022-10-14 13:47 ` Filipe Manana [this message]
2022-10-14 13:30 ` [PATCH 0/2] btrfs: drop no longer needed atomic allocation for tree mod log operations David Sterba
2022-10-14 13:44 ` [PATCH v2 " fdmanana
2022-10-14 13:44 ` [PATCH v2 1/2] btrfs: switch GFP_ATOMIC to GFP_NOFS when fixing up low keys fdmanana
2022-10-14 13:44 ` [PATCH v2 2/2] btrfs: remove gfp_t flag from btrfs_tree_mod_log_insert_key() fdmanana
2022-10-14 14:04 ` [PATCH v2 0/2] btrfs: drop no longer needed atomic allocation for tree mod log operations David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL3q7H4MWu6UuhcAbko51PuuV5ta6XP6V4Q_FBQuJybLM1vE7w@mail.gmail.com \
--to=fdmanana@kernel.org \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).