* [PATCH] Btrfs: fix wrong check for btrfs_force_chunk_alloc()
@ 2015-04-12 6:35 Wang Shilong
2015-06-30 22:25 ` Filipe David Manana
0 siblings, 1 reply; 3+ messages in thread
From: Wang Shilong @ 2015-04-12 6:35 UTC (permalink / raw)
To: linux-btrfs
btrfs_force_chunk_alloc() return 1 for allocation chunk successfully.
This problem exists since commit c87f08ca4.
With this patch, we might fix some enospc problems for balances.
Signed-off-by: Wang Shilong <wangshilong1991@gmail.com>
---
fs/btrfs/relocation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index d830853..c453464 100644
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -4037,7 +4037,7 @@ restart:
if (trans && progress && err == -ENOSPC) {
ret = btrfs_force_chunk_alloc(trans, rc->extent_root,
rc->block_group->flags);
- if (ret == 0) {
+ if (ret == 1) {
err = 0;
progress = 0;
goto restart;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Btrfs: fix wrong check for btrfs_force_chunk_alloc()
2015-04-12 6:35 [PATCH] Btrfs: fix wrong check for btrfs_force_chunk_alloc() Wang Shilong
@ 2015-06-30 22:25 ` Filipe David Manana
2015-07-01 2:49 ` Wang Shilong
0 siblings, 1 reply; 3+ messages in thread
From: Filipe David Manana @ 2015-06-30 22:25 UTC (permalink / raw)
To: Wang Shilong; +Cc: linux-btrfs@vger.kernel.org
On Sun, Apr 12, 2015 at 7:35 AM, Wang Shilong <wangshilong1991@gmail.com> wrote:
> btrfs_force_chunk_alloc() return 1 for allocation chunk successfully.
> This problem exists since commit c87f08ca4.
>
> With this patch, we might fix some enospc problems for balances.
>
> Signed-off-by: Wang Shilong <wangshilong1991@gmail.com>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Tested-by: Filipe Manana <fdmanana@suse.com>
> ---
> fs/btrfs/relocation.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
> index d830853..c453464 100644
> --- a/fs/btrfs/relocation.c
> +++ b/fs/btrfs/relocation.c
> @@ -4037,7 +4037,7 @@ restart:
> if (trans && progress && err == -ENOSPC) {
> ret = btrfs_force_chunk_alloc(trans, rc->extent_root,
> rc->block_group->flags);
> - if (ret == 0) {
> + if (ret == 1) {
> err = 0;
> progress = 0;
> goto restart;
> --
> 1.7.12.4
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Filipe David Manana,
"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Btrfs: fix wrong check for btrfs_force_chunk_alloc()
2015-06-30 22:25 ` Filipe David Manana
@ 2015-07-01 2:49 ` Wang Shilong
0 siblings, 0 replies; 3+ messages in thread
From: Wang Shilong @ 2015-07-01 2:49 UTC (permalink / raw)
To: fdmanana; +Cc: linux-btrfs@vger.kernel.org
> On Sun, Apr 12, 2015 at 7:35 AM, Wang Shilong <wangshilong1991@gmail.com> wrote:
>> btrfs_force_chunk_alloc() return 1 for allocation chunk successfully.
>> This problem exists since commit c87f08ca4.
>>
>> With this patch, we might fix some enospc problems for balances.
>>
>> Signed-off-by: Wang Shilong <wangshilong1991@gmail.com>
> Reviewed-by: Filipe Manana <fdmanana@suse.com>
> Tested-by: Filipe Manana <fdmanana@suse.com>
Thanks Filipe!
Regards,
Shilong
>
>> ---
>> fs/btrfs/relocation.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
>> index d830853..c453464 100644
>> --- a/fs/btrfs/relocation.c
>> +++ b/fs/btrfs/relocation.c
>> @@ -4037,7 +4037,7 @@ restart:
>> if (trans && progress && err == -ENOSPC) {
>> ret = btrfs_force_chunk_alloc(trans, rc->extent_root,
>> rc->block_group->flags);
>> - if (ret == 0) {
>> + if (ret == 1) {
>> err = 0;
>> progress = 0;
>> goto restart;
>> --
>> 1.7.12.4
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-01 2:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-12 6:35 [PATCH] Btrfs: fix wrong check for btrfs_force_chunk_alloc() Wang Shilong
2015-06-30 22:25 ` Filipe David Manana
2015-07-01 2:49 ` Wang Shilong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).