From: Filipe Manana <fdmanana@kernel.org>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/4] btrfs: remove redundant initialization from btrfs_readahead_tree_block()
Date: Wed, 16 Oct 2024 17:41:20 +0100 [thread overview]
Message-ID: <CAL3q7H5D4c3OOFQFq5WNW65muhXa-fQLFsdhu73wSdG8Zz6LxQ@mail.gmail.com> (raw)
In-Reply-To: <20241016154951.GR1609@twin.jikos.cz>
On Wed, Oct 16, 2024 at 4:49 PM David Sterba <dsterba@suse.cz> wrote:
>
> On Wed, Oct 16, 2024 at 03:20:22PM +0100, fdmanana@kernel.org wrote:
> > From: Filipe Manana <fdmanana@suse.com>
> >
> > It's pointless to initialize the has_first_key field of the stack local
> > btrfs_tree_parent_check structure since it all fields not explicitly
> > initialized are zeroed out, plus it's a bit odd because the field is
> > of type bool and we are assigning 0 instead of false to it (however it's
> > not incorrect since 0 is converted to false). Just remove the explicit
> > initialization due to its redundancy.
>
> Makes sense, I've noticed there's one more to remove from
> btrfs_qgroup_trace_subtree() you can squash it to this patch too.
Ah yes, done and added to for-next. Thanks.
next prev parent reply other threads:[~2024-10-16 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 14:20 [PATCH 0/4] btrfs: some cleanups around read_block_for_search() fdmanana
2024-10-16 14:20 ` [PATCH 1/4] btrfs: remove redundant level argument from read_block_for_search() fdmanana
2024-10-16 14:20 ` [PATCH 2/4] btrfs: simplify arguments for btrfs_verify_level_key() fdmanana
2024-10-16 14:20 ` [PATCH 3/4] btrfs: remove redundant initialization from btrfs_readahead_tree_block() fdmanana
2024-10-16 15:49 ` David Sterba
2024-10-16 16:41 ` Filipe Manana [this message]
2024-10-16 14:20 ` [PATCH 4/4] btrfs: remove local generation variable from read_block_for_search() fdmanana
2024-10-16 16:00 ` [PATCH 0/4] btrfs: some cleanups around read_block_for_search() David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL3q7H5D4c3OOFQFq5WNW65muhXa-fQLFsdhu73wSdG8Zz6LxQ@mail.gmail.com \
--to=fdmanana@kernel.org \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).