public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Filipe Manana <fdmanana@kernel.org>
To: "Miquel Sabaté Solà" <mssola@mssola.com>
Cc: dsterba@suse.com, clm@fb.com, linux-btrfs@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: report filesystem shutdown via fserror
Date: Fri, 27 Feb 2026 09:29:10 +0000	[thread overview]
Message-ID: <CAL3q7H5YHefunytYMjH+sBN=6K2d8=RsWkpZjTKA6wUAvrO1Nw@mail.gmail.com> (raw)
In-Reply-To: <6995a98f.170a0220.4341d.d20aSMTPIN_ADDED_BROKEN@mx.google.com>

On Wed, Feb 18, 2026 at 11:59 AM Miquel Sabaté Solà <mssola@mssola.com> wrote:
>
> Filipe Manana @ 2026-02-18 11:54 GMT:
>
> > On Mon, Feb 16, 2026 at 3:01 AM Miquel Sabaté Solà <mssola@mssola.com> wrote:
> >>
> >> Commit 347b7042fb26 ("Merge patch series "fs: generic file IO error
> >> reporting"") has introduced a common framework for reporting errors to
> >> fsnotify in a standard way.
> >>
> >> One of the functions being introduced is 'fserror_report_shutdown' that,
> >> when combined with the experimental support for shutdown in btrfs, it
> >> means that user-space can also easily detect whenever a btrfs filesystem
> >> has been marked as shutdown.
> >>
> >> Signed-off-by: Miquel Sabaté Solà <mssola@mssola.com>
> >
> > Reviewed-by: Filipe Manana <fdmanana@suse.com>
> >
> > Once the for-next branch is based on the next kernel rc that includes
> > the new function, I can push the patch there.

Now pushed into the for-next github branch.

>
> Thanks for taking care of this!
>
> >
> > Thanks.
> >
> >> ---
> >> Note that the for-next branch does not include the mentioned commit. I've
> >> built and tested this patch on top of current Linus' tree.
> >>
> >>  fs/btrfs/fs.h | 5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/fs/btrfs/fs.h b/fs/btrfs/fs.h
> >> index 3de3b517810e..92fcebf5766e 100644
> >> --- a/fs/btrfs/fs.h
> >> +++ b/fs/btrfs/fs.h
> >> @@ -33,6 +33,7 @@
> >>  #include "async-thread.h"
> >>  #include "block-rsv.h"
> >>  #include "messages.h"
> >> +#include <linux/fserror.h>
> >>
> >>  struct inode;
> >>  struct super_block;
> >> @@ -1199,8 +1200,10 @@ static inline void btrfs_force_shutdown(struct btrfs_fs_info *fs_info)
> >>          * So here we only mark the fs error without flipping it RO.
> >>          */
> >>         WRITE_ONCE(fs_info->fs_error, -EIO);
> >> -       if (!test_and_set_bit(BTRFS_FS_STATE_EMERGENCY_SHUTDOWN, &fs_info->fs_state))
> >> +       if (!test_and_set_bit(BTRFS_FS_STATE_EMERGENCY_SHUTDOWN, &fs_info->fs_state)) {
> >>                 btrfs_crit(fs_info, "emergency shutdown");
> >> +               fserror_report_shutdown(fs_info->sb, GFP_KERNEL);
> >> +       }
> >>  }
> >>
> >>  /*
> >> --
> >> 2.53.0
> >>

      parent reply	other threads:[~2026-02-27  9:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-16  0:28 [PATCH] btrfs: report filesystem shutdown via fserror Miquel Sabaté Solà
2026-02-18 11:54 ` Filipe Manana
2026-02-18 11:58   ` Miquel Sabaté Solà
     [not found]   ` <6995a98f.170a0220.4341d.d20aSMTPIN_ADDED_BROKEN@mx.google.com>
2026-02-27  9:29     ` Filipe Manana [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL3q7H5YHefunytYMjH+sBN=6K2d8=RsWkpZjTKA6wUAvrO1Nw@mail.gmail.com' \
    --to=fdmanana@kernel.org \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mssola@mssola.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox