* Re: [PATCH 1/3] common/rc: test that xfs_io's falloc command supports specific flags [not found] <1491287671-23097-1-git-send-email-fdmanana@kernel.org> @ 2017-04-06 14:18 ` Eryu Guan 2017-04-06 14:20 ` Filipe Manana 2017-04-07 8:51 ` Eryu Guan 1 sibling, 1 reply; 6+ messages in thread From: Eryu Guan @ 2017-04-06 14:18 UTC (permalink / raw) To: fdmanana; +Cc: fstests, linux-btrfs, Filipe Manana On Tue, Apr 04, 2017 at 07:34:29AM +0100, fdmanana@kernel.org wrote: > From: Filipe Manana <fdmanana@suse.com> > > For example NFS 4.2 supports fallocate but it does not support its > KEEP_SIZE flag, so we want to skip tests that use fallocate with that > flag on filesystems that don't support it. > > Suggested-by: Eryu Guan <eguan@redhat.com> > Signed-off-by: Filipe Manana <fdmanana@suse.com> > --- > common/rc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/rc b/common/rc > index e1ab2c6..3d0f089 100644 > --- a/common/rc > +++ b/common/rc > @@ -2021,8 +2021,8 @@ _require_xfs_io_command() > "chproj") > testio=`$XFS_IO_PROG -F -f -c "chproj 0" $testfile 2>&1` > ;; > - "falloc" ) > - testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1` > + "falloc*" ) This doesn't work as expected with quotes. I can remove the quotes at commit time though. Thanks, Eryu > + testio=`$XFS_IO_PROG -F -f -c "$command 0 1m" $testfile 2>&1` > ;; > "fpunch" | "fcollapse" | "zero" | "fzero" | "finsert" | "funshare") > testio=`$XFS_IO_PROG -F -f -c "pwrite 0 20k" -c "fsync" \ > -- > 2.7.0.rc3 > > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] common/rc: test that xfs_io's falloc command supports specific flags 2017-04-06 14:18 ` [PATCH 1/3] common/rc: test that xfs_io's falloc command supports specific flags Eryu Guan @ 2017-04-06 14:20 ` Filipe Manana 2017-04-06 14:28 ` David Sterba 0 siblings, 1 reply; 6+ messages in thread From: Filipe Manana @ 2017-04-06 14:20 UTC (permalink / raw) To: Eryu Guan; +Cc: fstests, linux-btrfs@vger.kernel.org, Filipe Manana On Thu, Apr 6, 2017 at 3:18 PM, Eryu Guan <eguan@redhat.com> wrote: > On Tue, Apr 04, 2017 at 07:34:29AM +0100, fdmanana@kernel.org wrote: >> From: Filipe Manana <fdmanana@suse.com> >> >> For example NFS 4.2 supports fallocate but it does not support its >> KEEP_SIZE flag, so we want to skip tests that use fallocate with that >> flag on filesystems that don't support it. >> >> Suggested-by: Eryu Guan <eguan@redhat.com> >> Signed-off-by: Filipe Manana <fdmanana@suse.com> >> --- >> common/rc | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/common/rc b/common/rc >> index e1ab2c6..3d0f089 100644 >> --- a/common/rc >> +++ b/common/rc >> @@ -2021,8 +2021,8 @@ _require_xfs_io_command() >> "chproj") >> testio=`$XFS_IO_PROG -F -f -c "chproj 0" $testfile 2>&1` >> ;; >> - "falloc" ) >> - testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1` >> + "falloc*" ) > > This doesn't work as expected with quotes. I can remove the quotes at > commit time though. Hum, it did work for me, strange. But please do, thanks. > > Thanks, > Eryu > >> + testio=`$XFS_IO_PROG -F -f -c "$command 0 1m" $testfile 2>&1` >> ;; >> "fpunch" | "fcollapse" | "zero" | "fzero" | "finsert" | "funshare") >> testio=`$XFS_IO_PROG -F -f -c "pwrite 0 20k" -c "fsync" \ >> -- >> 2.7.0.rc3 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe fstests" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] common/rc: test that xfs_io's falloc command supports specific flags 2017-04-06 14:20 ` Filipe Manana @ 2017-04-06 14:28 ` David Sterba 0 siblings, 0 replies; 6+ messages in thread From: David Sterba @ 2017-04-06 14:28 UTC (permalink / raw) To: Filipe Manana Cc: Eryu Guan, fstests, linux-btrfs@vger.kernel.org, Filipe Manana On Thu, Apr 06, 2017 at 03:20:43PM +0100, Filipe Manana wrote: > On Thu, Apr 6, 2017 at 3:18 PM, Eryu Guan <eguan@redhat.com> wrote: > > On Tue, Apr 04, 2017 at 07:34:29AM +0100, fdmanana@kernel.org wrote: > >> From: Filipe Manana <fdmanana@suse.com> > >> > >> For example NFS 4.2 supports fallocate but it does not support its > >> KEEP_SIZE flag, so we want to skip tests that use fallocate with that > >> flag on filesystems that don't support it. > >> > >> Suggested-by: Eryu Guan <eguan@redhat.com> > >> Signed-off-by: Filipe Manana <fdmanana@suse.com> > >> --- > >> common/rc | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/common/rc b/common/rc > >> index e1ab2c6..3d0f089 100644 > >> --- a/common/rc > >> +++ b/common/rc > >> @@ -2021,8 +2021,8 @@ _require_xfs_io_command() > >> "chproj") > >> testio=`$XFS_IO_PROG -F -f -c "chproj 0" $testfile 2>&1` > >> ;; > >> - "falloc" ) > >> - testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1` > >> + "falloc*" ) > > > > This doesn't work as expected with quotes. I can remove the quotes at > > commit time though. > > Hum, it did work for me, strange. Quoted globs don't work the same way as unquoted inside case, this #!/bin/sh i=abc case $i in abc*) echo notquoted;; "abc*") echo quoted;; esac --- will return 'notquoted' ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] common/rc: test that xfs_io's falloc command supports specific flags [not found] <1491287671-23097-1-git-send-email-fdmanana@kernel.org> 2017-04-06 14:18 ` [PATCH 1/3] common/rc: test that xfs_io's falloc command supports specific flags Eryu Guan @ 2017-04-07 8:51 ` Eryu Guan 2017-04-07 9:13 ` Filipe Manana 1 sibling, 1 reply; 6+ messages in thread From: Eryu Guan @ 2017-04-07 8:51 UTC (permalink / raw) To: fdmanana; +Cc: fstests, linux-btrfs, Filipe Manana On Tue, Apr 04, 2017 at 07:34:29AM +0100, fdmanana@kernel.org wrote: > From: Filipe Manana <fdmanana@suse.com> > > For example NFS 4.2 supports fallocate but it does not support its > KEEP_SIZE flag, so we want to skip tests that use fallocate with that > flag on filesystems that don't support it. > > Suggested-by: Eryu Guan <eguan@redhat.com> > Signed-off-by: Filipe Manana <fdmanana@suse.com> > --- > common/rc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/rc b/common/rc > index e1ab2c6..3d0f089 100644 > --- a/common/rc > +++ b/common/rc > @@ -2021,8 +2021,8 @@ _require_xfs_io_command() > "chproj") > testio=`$XFS_IO_PROG -F -f -c "chproj 0" $testfile 2>&1` > ;; > - "falloc" ) > - testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1` > + "falloc*" ) > + testio=`$XFS_IO_PROG -F -f -c "$command 0 1m" $testfile 2>&1` Sorry, I was wrong about this. It would break the subsequent $XFS_IO_PROG -c "help $command" | grep ... command if another $param is specified. Seems adding $param to falloc command is the right way, as what Darrick did to fiemap in his new test. - testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1` + testio=`$XFS_IO_PROG -F -f -c "falloc $param 0 1m" $testfile 2>&1` Do you mind me updating these three patches accordingly? Or can you send out new version if you like? Thanks! And sorry again! Eryu P.S. I'm thinking of converting all the case switches (except the default one) in _require_xfs_io_command() to actually run the $command with $param, and doing other cleanups, but that won't block this patch and I can do it in another patch. > ;; > "fpunch" | "fcollapse" | "zero" | "fzero" | "finsert" | "funshare") > testio=`$XFS_IO_PROG -F -f -c "pwrite 0 20k" -c "fsync" \ > -- > 2.7.0.rc3 > > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] common/rc: test that xfs_io's falloc command supports specific flags 2017-04-07 8:51 ` Eryu Guan @ 2017-04-07 9:13 ` Filipe Manana 2017-04-07 9:45 ` Eryu Guan 0 siblings, 1 reply; 6+ messages in thread From: Filipe Manana @ 2017-04-07 9:13 UTC (permalink / raw) To: Eryu Guan; +Cc: fstests, linux-btrfs@vger.kernel.org, Filipe Manana On Fri, Apr 7, 2017 at 9:51 AM, Eryu Guan <eguan@redhat.com> wrote: > On Tue, Apr 04, 2017 at 07:34:29AM +0100, fdmanana@kernel.org wrote: >> From: Filipe Manana <fdmanana@suse.com> >> >> For example NFS 4.2 supports fallocate but it does not support its >> KEEP_SIZE flag, so we want to skip tests that use fallocate with that >> flag on filesystems that don't support it. >> >> Suggested-by: Eryu Guan <eguan@redhat.com> >> Signed-off-by: Filipe Manana <fdmanana@suse.com> >> --- >> common/rc | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/common/rc b/common/rc >> index e1ab2c6..3d0f089 100644 >> --- a/common/rc >> +++ b/common/rc >> @@ -2021,8 +2021,8 @@ _require_xfs_io_command() >> "chproj") >> testio=`$XFS_IO_PROG -F -f -c "chproj 0" $testfile 2>&1` >> ;; >> - "falloc" ) >> - testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1` >> + "falloc*" ) >> + testio=`$XFS_IO_PROG -F -f -c "$command 0 1m" $testfile 2>&1` > > Sorry, I was wrong about this. It would break the subsequent > $XFS_IO_PROG -c "help $command" | grep ... command if another $param is > specified. Yeah I had noticed that because the following won't cause the return anymore: test -z "$param" && return > Seems adding $param to falloc command is the right way, as > what Darrick did to fiemap in his new test. > > - testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1` > + testio=`$XFS_IO_PROG -F -f -c "falloc $param 0 1m" $testfile 2>&1` But in that case grepping the help output, at the very end of the function, will fail for falloc since its help output fails to match the grep pattern (as highlighted in the thread you pointed before). So that grep pattern would have to change as well. > > Do you mind me updating these three patches accordingly? Or can you send > out new version if you like? Sure, fell free to update it as you feel it's the best way. Thanks! > > Thanks! And sorry again! > > Eryu > > P.S. I'm thinking of converting all the case switches (except the > default one) in _require_xfs_io_command() to actually run the $command > with $param, and doing other cleanups, but that won't block this patch > and I can do it in another patch. > >> ;; >> "fpunch" | "fcollapse" | "zero" | "fzero" | "finsert" | "funshare") >> testio=`$XFS_IO_PROG -F -f -c "pwrite 0 20k" -c "fsync" \ >> -- >> 2.7.0.rc3 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe fstests" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] common/rc: test that xfs_io's falloc command supports specific flags 2017-04-07 9:13 ` Filipe Manana @ 2017-04-07 9:45 ` Eryu Guan 0 siblings, 0 replies; 6+ messages in thread From: Eryu Guan @ 2017-04-07 9:45 UTC (permalink / raw) To: Filipe Manana; +Cc: fstests, linux-btrfs@vger.kernel.org, Filipe Manana On Fri, Apr 07, 2017 at 10:13:09AM +0100, Filipe Manana wrote: > On Fri, Apr 7, 2017 at 9:51 AM, Eryu Guan <eguan@redhat.com> wrote: > > On Tue, Apr 04, 2017 at 07:34:29AM +0100, fdmanana@kernel.org wrote: > >> From: Filipe Manana <fdmanana@suse.com> > >> > >> For example NFS 4.2 supports fallocate but it does not support its > >> KEEP_SIZE flag, so we want to skip tests that use fallocate with that > >> flag on filesystems that don't support it. > >> > >> Suggested-by: Eryu Guan <eguan@redhat.com> > >> Signed-off-by: Filipe Manana <fdmanana@suse.com> > >> --- > >> common/rc | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/common/rc b/common/rc > >> index e1ab2c6..3d0f089 100644 > >> --- a/common/rc > >> +++ b/common/rc > >> @@ -2021,8 +2021,8 @@ _require_xfs_io_command() > >> "chproj") > >> testio=`$XFS_IO_PROG -F -f -c "chproj 0" $testfile 2>&1` > >> ;; > >> - "falloc" ) > >> - testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1` > >> + "falloc*" ) > >> + testio=`$XFS_IO_PROG -F -f -c "$command 0 1m" $testfile 2>&1` > > > > Sorry, I was wrong about this. It would break the subsequent > > $XFS_IO_PROG -c "help $command" | grep ... command if another $param is > > specified. > > Yeah I had noticed that because the following won't cause the return anymore: > > test -z "$param" && return > > > Seems adding $param to falloc command is the right way, as > > what Darrick did to fiemap in his new test. > > > > - testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1` > > + testio=`$XFS_IO_PROG -F -f -c "falloc $param 0 1m" $testfile 2>&1` > > But in that case grepping the help output, at the very end of the > function, will fail for falloc since its help output fails to match > the grep pattern (as highlighted in the thread you pointed before). > So that grep pattern would have to change as well. This should be fixed by xfsprogs commit 0c2ed80a3590 ("xfs_io: provide long-format help for falloc"). But I agreed searching the help message again for it would be redundant. But perhaps that needs wider review and doesn't belong to this patch. I'll try to do that in my cleanup patch for _require_xfs_io_command(). Thanks, Eryu > > > > > Do you mind me updating these three patches accordingly? Or can you send > > out new version if you like? > > Sure, fell free to update it as you feel it's the best way. > > Thanks! > > > > > Thanks! And sorry again! > > > > Eryu > > > > P.S. I'm thinking of converting all the case switches (except the > > default one) in _require_xfs_io_command() to actually run the $command > > with $param, and doing other cleanups, but that won't block this patch > > and I can do it in another patch. > > > >> ;; > >> "fpunch" | "fcollapse" | "zero" | "fzero" | "finsert" | "funshare") > >> testio=`$XFS_IO_PROG -F -f -c "pwrite 0 20k" -c "fsync" \ > >> -- > >> 2.7.0.rc3 > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe fstests" in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-07 9:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1491287671-23097-1-git-send-email-fdmanana@kernel.org>
2017-04-06 14:18 ` [PATCH 1/3] common/rc: test that xfs_io's falloc command supports specific flags Eryu Guan
2017-04-06 14:20 ` Filipe Manana
2017-04-06 14:28 ` David Sterba
2017-04-07 8:51 ` Eryu Guan
2017-04-07 9:13 ` Filipe Manana
2017-04-07 9:45 ` Eryu Guan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).