From: Filipe David Manana <fdmanana@gmail.com>
To: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v3] Btrfs: fix tree mod logging
Date: Fri, 20 Dec 2013 23:31:44 +0000 [thread overview]
Message-ID: <CAL3q7H6GPTJVFEj3SCtoPgOE_qQHs8Zik40HGsxDAY4b6yf9FQ@mail.gmail.com> (raw)
In-Reply-To: <pan.2013.12.20.23.19.56@googlemail.com>
On Fri, Dec 20, 2013 at 11:19 PM, Holger Hoffstätte
<holger.hoffstaette@googlemail.com> wrote:
> On Fri, 20 Dec 2013 15:17:46 +0000, Filipe David Borba Manana wrote:
>
> [..patch..]
>
> I applied this to 3.12.6 and was rewarded with:
>
> *fs/btrfs/ctree.c: In function 'tree_mod_log_set_node_key':
> *fs/btrfs/ctree.c:924:2: error: implicit declaration of function
> '__tree_mod_log_insert_key' [-Werror=implicit-function-declaration]
> * ret = __tree_mod_log_insert_key(fs_info, eb, slot,
> * ^
> *cc1: some warnings being treated as errors
> *scripts/Makefile.build:308: recipe for target 'fs/btrfs/ctree.o' failed
>
> Said function prototype is nowhere to be found, only the regular non-
> scoped function. Did you just miss this call? Changing the call to the
> remaining tree_mod_log_insert_key() looks like what was intended and
> compiles, but I wanted to check before I burn the house down. :)
Did you apply first the patch titled "Btrfs: return immediately if
tree log mod is not necessary" ?
It depends on that one, and both are targeted against btrfs-next
repository from Josef. Didn't try 3.12.* at all.
Thanks
>
> -h
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Filipe David Manana,
"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."
next prev parent reply other threads:[~2013-12-20 23:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 19:41 [PATCH] Btrfs: fix tree mod logging Filipe David Borba Manana
2013-12-13 20:06 ` Josef Bacik
2013-12-13 20:10 ` Filipe David Manana
2013-12-13 20:49 ` Josef Bacik
2013-12-13 22:57 ` [PATCH v2] " Filipe David Borba Manana
2013-12-19 7:37 ` Ahmet Inan
2013-12-19 20:17 ` Filipe David Manana
2013-12-20 15:17 ` [PATCH v3] " Filipe David Borba Manana
2013-12-20 23:19 ` Holger Hoffstätte
2013-12-20 23:31 ` Filipe David Manana [this message]
2013-12-20 23:52 ` Holger Hoffstätte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL3q7H6GPTJVFEj3SCtoPgOE_qQHs8Zik40HGsxDAY4b6yf9FQ@mail.gmail.com \
--to=fdmanana@gmail.com \
--cc=holger.hoffstaette@googlemail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).