* [PATCH] fstest: btrfs: update 048.out inline with ui changes
@ 2016-03-24 10:11 Anand Jain
2016-03-24 11:10 ` Filipe Manana
2016-03-24 11:13 ` Eryu Guan
0 siblings, 2 replies; 4+ messages in thread
From: Anand Jain @ 2016-03-24 10:11 UTC (permalink / raw)
To: fstests; +Cc: linux-btrfs
To be inline with progs changes
28831d54895443e5fc795392f23ce3a8b122cb71
btrfs-progs: cmd property: switch to common error message wrapper
update 048.out
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
tests/btrfs/048.out | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/btrfs/048.out b/tests/btrfs/048.out
index 0b20d0b5976c..1d3ccef8e870 100644
--- a/tests/btrfs/048.out
+++ b/tests/btrfs/048.out
@@ -9,7 +9,7 @@ label=foobar
***
label=
***
-ERROR: object is not compatible with property
+ERROR: object is not compatible with property: label
***
Testing subvolume ro property
--
2.7.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fstest: btrfs: update 048.out inline with ui changes
2016-03-24 10:11 [PATCH] fstest: btrfs: update 048.out inline with ui changes Anand Jain
@ 2016-03-24 11:10 ` Filipe Manana
2016-03-24 11:13 ` Eryu Guan
1 sibling, 0 replies; 4+ messages in thread
From: Filipe Manana @ 2016-03-24 11:10 UTC (permalink / raw)
To: Anand Jain; +Cc: fstests, linux-btrfs@vger.kernel.org
On Thu, Mar 24, 2016 at 10:11 AM, Anand Jain <anand.jain@oracle.com> wrote:
> To be inline with progs changes
> 28831d54895443e5fc795392f23ce3a8b122cb71
> btrfs-progs: cmd property: switch to common error message wrapper
> update 048.out
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> tests/btrfs/048.out | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/048.out b/tests/btrfs/048.out
> index 0b20d0b5976c..1d3ccef8e870 100644
> --- a/tests/btrfs/048.out
> +++ b/tests/btrfs/048.out
> @@ -9,7 +9,7 @@ label=foobar
> ***
> label=
> ***
> -ERROR: object is not compatible with property
> +ERROR: object is not compatible with property: label
This now makes the test fail with older versions of btrfs-progs...
Same observation as before, update your git branch and read the mailing list:
https://git.kernel.org/cgit/fs/xfs/xfstests-dev.git/commit/?id=232593dea51c53f3251f9b41cd89e9dba20f0159
https://git.kernel.org/cgit/fs/xfs/xfstests-dev.git/commit/?id=2dd2cea4b51810bbb4090ebdc20ee799e63e5fd8
> ***
>
> Testing subvolume ro property
> --
> 2.7.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Filipe David Manana,
"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fstest: btrfs: update 048.out inline with ui changes
2016-03-24 10:11 [PATCH] fstest: btrfs: update 048.out inline with ui changes Anand Jain
2016-03-24 11:10 ` Filipe Manana
@ 2016-03-24 11:13 ` Eryu Guan
2016-03-24 11:16 ` Anand Jain
1 sibling, 1 reply; 4+ messages in thread
From: Eryu Guan @ 2016-03-24 11:13 UTC (permalink / raw)
To: Anand Jain; +Cc: fstests, linux-btrfs
On Thu, Mar 24, 2016 at 06:11:12PM +0800, Anand Jain wrote:
> To be inline with progs changes
> 28831d54895443e5fc795392f23ce3a8b122cb71
> btrfs-progs: cmd property: switch to common error message wrapper
> update 048.out
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> tests/btrfs/048.out | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/048.out b/tests/btrfs/048.out
> index 0b20d0b5976c..1d3ccef8e870 100644
> --- a/tests/btrfs/048.out
> +++ b/tests/btrfs/048.out
> @@ -9,7 +9,7 @@ label=foobar
> ***
> label=
> ***
> -ERROR: object is not compatible with property
> +ERROR: object is not compatible with property: label
This fails test with old btrfs-progs. I think a filter can be added to
btrfs/048 to filter out the ": label" part, so that test passes with
both old and new btrfs-progs.
Thanks,
Eryu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fstest: btrfs: update 048.out inline with ui changes
2016-03-24 11:13 ` Eryu Guan
@ 2016-03-24 11:16 ` Anand Jain
0 siblings, 0 replies; 4+ messages in thread
From: Anand Jain @ 2016-03-24 11:16 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests, linux-btrfs
On 03/24/2016 07:13 PM, Eryu Guan wrote:
> On Thu, Mar 24, 2016 at 06:11:12PM +0800, Anand Jain wrote:
>> To be inline with progs changes
>> 28831d54895443e5fc795392f23ce3a8b122cb71
>> btrfs-progs: cmd property: switch to common error message wrapper
>> update 048.out
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
>> tests/btrfs/048.out | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/btrfs/048.out b/tests/btrfs/048.out
>> index 0b20d0b5976c..1d3ccef8e870 100644
>> --- a/tests/btrfs/048.out
>> +++ b/tests/btrfs/048.out
>> @@ -9,7 +9,7 @@ label=foobar
>> ***
>> label=
>> ***
>> -ERROR: object is not compatible with property
>> +ERROR: object is not compatible with property: label
>
> This fails test with old btrfs-progs. I think a filter can be added to
> btrfs/048 to filter out the ": label" part, so that test passes with
> both old and new btrfs-progs.
Thanks. Yep. I shall do that.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-24 11:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-24 10:11 [PATCH] fstest: btrfs: update 048.out inline with ui changes Anand Jain
2016-03-24 11:10 ` Filipe Manana
2016-03-24 11:13 ` Eryu Guan
2016-03-24 11:16 ` Anand Jain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).