From: Filipe David Manana <fdmanana@gmail.com>
To: Stefan Behrens <sbehrens@giantdisaster.de>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 4/5] Btrfs-progs: return error on write failure in make_btrfs()
Date: Thu, 8 Aug 2013 11:56:07 +0100 [thread overview]
Message-ID: <CAL3q7H6MsUZygwuv_nyu2PJLP5fRPtGSeGknDAXXmQRFXJiCrg@mail.gmail.com> (raw)
In-Reply-To: <5203786A.3000306@giantdisaster.de>
On Thu, Aug 8, 2013 at 11:52 AM, Stefan Behrens
<sbehrens@giantdisaster.de> wrote:
> On Thu, 4 Jul 2013 10:48:39 +0100, Filipe David Borba Manana wrote:
>> Instead of aborting with a BUG_ON() statement, return a
>> negated errno code. Also updated mkfs and convert tools
>> to print a nicer error message when make_btrfs() returns
>> an error.
>>
>> Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com>
> [...]
>> ret = pwrite(fd, buf->data, sectorsize, blocks[0]);
>> - BUG_ON(ret != sectorsize);
>> -
>> + if (ret < 0)
>> + return -errno;
>> + else if (ret != leafsize)
>> + return -EIO;
>
> mkfs.btrfs with leafsize != sectorsize fails. I've sent a patch for it.
Copy paste error :(
Thanks for catching and fixing it.
>
--
Filipe David Manana,
"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."
next prev parent reply other threads:[~2013-08-08 10:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-30 11:51 [PATCH 0/3] Small fixes for btrfs-progs Filipe David Borba Manana
2013-06-30 11:51 ` [PATCH 1/3] Btrfs-progs: add missing write check for mkfs Filipe David Borba Manana
2013-07-03 17:09 ` David Sterba
2013-07-03 17:25 ` Filipe David Manana
2013-07-03 21:12 ` David Sterba
2013-06-30 11:51 ` [PATCH 2/3] Btrfs-progs: add kstrdup() return value check Filipe David Borba Manana
2013-06-30 11:51 ` [PATCH 3/3] Btrfs-progs: remove unused code Filipe David Borba Manana
2013-07-01 8:21 ` Anand Jain
2013-07-03 17:30 ` [PATCH v2 1/3] Btrfs-progs: add missing write check for mkfs Filipe David Borba Manana
2013-07-03 17:32 ` [PATCH v2 3/3] Btrfs-progs: remove unused code Filipe David Borba Manana
2013-07-04 9:48 ` [PATCH v2 0/5] Small fixes for btrfs-progs Filipe David Borba Manana
2013-07-04 9:48 ` [PATCH 4/5] Btrfs-progs: return error on write failure in make_btrfs() Filipe David Borba Manana
2013-08-08 10:52 ` Stefan Behrens
2013-08-08 10:56 ` Filipe David Manana [this message]
2013-07-04 9:48 ` [PATCH 5/5] Btrfs-progs: don't ignore errors in btrfs_add_block_group() Filipe David Borba Manana
2013-07-08 13:21 ` [PATCH v2 5/5] Btrfs-progs: don't ignore errors in extent-tree.c Filipe David Borba Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL3q7H6MsUZygwuv_nyu2PJLP5fRPtGSeGknDAXXmQRFXJiCrg@mail.gmail.com \
--to=fdmanana@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sbehrens@giantdisaster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).