linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Filipe Manana <fdmanana@gmail.com>
To: Simon Quigley <tsimonq2@ubuntu.com>
Cc: Philippe Loctaux <phil@philippeloctaux.com>,
	Qu Wenruo <quwenruo@cn.fujitsu.com>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [Question]: Contributing to btrfs
Date: Mon, 22 Feb 2016 13:29:31 +0000	[thread overview]
Message-ID: <CAL3q7H7hhaDQ3e2oCW96iwr6NPww-57e9b675oQ-MY6EVTrVQA@mail.gmail.com> (raw)
In-Reply-To: <1456142520.3587.3.camel@ubuntu.com>

On Mon, Feb 22, 2016 at 12:02 PM, Simon Quigley <tsimonq2@ubuntu.com> wrote:
>> 1) You don't learn anything by doing them. You don't learn nothing
>> about btrfs internals, filesystems in general, kernel programming in
>> general, general programming in C, etc. It ends up being only a waste
>> of time for you;
>
> It is useful for one reason. If you would like to get used to the workflow of kernel development,

No, that's silly. Generating a patch file and sending it to the
mailing list is very trivial. There's not much to learn there.
Certainly you don't need to send around 10 whitespace/style patches
for that. 1 is enough to "test the waters". And most people learn that
by observing others for a while too.

> this seems to be useful for a lot of people. In fact, Linus himself has encouraged this.

Whitespace/style patches I doubt. He probably encourages for small
cleanup/optimizations as the first patch, like he did recently at
https://lkml.org/lkml/2015/9/15/919. That's something that requires
some thinking and understanding. Now running checkpatch and fix its
warnings, doesn't require any skill at all.
What were you planning? Sending more 100 patches, each one to fix a
different style issue for each function? There's probably hundreds or
thousands more style/whitespace "issues" to fix in btrfs alone.

Just think about what you want to accomplish. It's normal to not know
what do initially, I think everyone goes through that phase, specially
if not employed to work on btrfs (or whatever project interests you).
Just read code, find issues in it, make changes for your own testing,
read bug reports and performance issue reports here in the list and in
kernel's bugzilla - some bugs might be easy to fix, other might
require very deep knowledge of the internals or no one figured out yet
how to reproduce. Or run xfstests and filesystem stress testing tools
to find problems (there's plenty of races, deadlocks, etc that happen
often and no one knows about them yet). Over time you'll find plenty
of things to do, that make you learn a lot and do something useful for
users and other developers.




-- 
Filipe David Manana,

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."

  reply	other threads:[~2016-02-22 13:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-20 21:09 [Question]: Contributing to btrfs Philippe Loctaux
2016-02-20 22:40 ` Philippe Loctaux
2016-02-21  6:14   ` Duncan
2016-02-22  1:18   ` Qu Wenruo
2016-02-22  7:26     ` Philippe Loctaux
2016-02-22  7:34       ` Qu Wenruo
2016-02-22  7:42         ` Philippe Loctaux
2016-02-22 10:47       ` Filipe Manana
2016-02-22 12:02         ` Simon Quigley
2016-02-22 13:29           ` Filipe Manana [this message]
2016-02-22 14:45             ` Simon Quigley
2016-02-23  1:32               ` Qu Wenruo
2016-02-23  2:07                 ` Simon Quigley
2016-02-23  2:20                   ` Qu Wenruo
2016-02-22 16:45             ` Philippe Loctaux
2016-02-22 12:18         ` David Sterba
2016-02-22 16:41           ` Philippe Loctaux
2016-02-22 17:15             ` David Sterba
2016-02-22 11:34 ` David Sterba
2016-02-22 16:38   ` Philippe Loctaux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL3q7H7hhaDQ3e2oCW96iwr6NPww-57e9b675oQ-MY6EVTrVQA@mail.gmail.com \
    --to=fdmanana@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=phil@philippeloctaux.com \
    --cc=quwenruo@cn.fujitsu.com \
    --cc=tsimonq2@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).