From: Filipe Manana <fdmanana@kernel.org>
To: dsterba@suse.cz, Filipe Manana <fdmanana@kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] Btrfs: include error on messages about failure to write space/inode caches
Date: Tue, 19 May 2020 14:18:30 +0100 [thread overview]
Message-ID: <CAL3q7H7meKUXYbKVcayJvZ37NzkNwBNaJs_AZ2EDzEmCD6-Dcw@mail.gmail.com> (raw)
In-Reply-To: <20200519130610.GC18421@twin.jikos.cz>
On Tue, May 19, 2020 at 2:07 PM David Sterba <dsterba@suse.cz> wrote:
>
> On Mon, May 18, 2020 at 05:34:11PM +0100, fdmanana@kernel.org wrote:
> > From: Filipe Manana <fdmanana@suse.com>
> >
> > Currently the error messages logged when we fail to write a free space
> > cache or an inode cache are not very useful as they don't mention what
> > was the error. So include the error number in the messages.
> >
> > Signed-off-by: Filipe Manana <fdmanana@suse.com>
>
> 1 and 2 added to misc-next, thanks.
>
> As the 2nd patch fixes a problem introduced in this dev cycle it's ok
> push it as a regression fix. But as we're at rc6 I'd prefer to postpone
> it for the merge window time, unless it's really annoying and hinders
> testing.
Agreed. I consider it a very minor thing.
Thanks.
prev parent reply other threads:[~2020-05-19 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 16:34 [PATCH 1/2] Btrfs: include error on messages about failure to write space/inode caches fdmanana
2020-05-19 13:06 ` David Sterba
2020-05-19 13:18 ` Filipe Manana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL3q7H7meKUXYbKVcayJvZ37NzkNwBNaJs_AZ2EDzEmCD6-Dcw@mail.gmail.com \
--to=fdmanana@kernel.org \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).