Re: [PATCH] Btrfs-progs: fix a regression in mkfs.btrfs

[Filipe David Manana <fdmanana@gmail.com>]

On Thu, Aug 8, 2013 at 11:51 AM, Stefan Behrens
<sbehrens@giantdisaster.de> wrote:
> Commit 55061a98 adds a cut & paste error that makes mkfs.btrfs fail
> if leafsize != sectorsize.
>
> Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de>
> ---
>  utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils.c b/utils.c
> index 15b991f..691b075 100644
> --- a/utils.c
> +++ b/utils.c
> @@ -430,7 +430,7 @@ int make_btrfs(int fd, const char *device, const char *label,
>         ret = pwrite(fd, buf->data, sectorsize, blocks[0]);
>         if (ret < 0)
>                 return -errno;
> -       else if (ret != leafsize)
> +       else if (ret != sectorsize)
>                 return -EIO;

Reviewed-by: Filipe Manana <fdmanana@gmail.com>

>
>         free(buf);
> --
> 1.8.3.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Filipe David Manana,

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."