From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f53.google.com ([209.85.167.53]:34121 "EHLO mail-lf1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728353AbeIQBg6 (ORCPT ); Sun, 16 Sep 2018 21:36:58 -0400 Received: by mail-lf1-f53.google.com with SMTP id c29-v6so11805661lfj.1 for ; Sun, 16 Sep 2018 13:12:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adrian Bastholm Date: Sun, 16 Sep 2018 22:12:12 +0200 Message-ID: Subject: Fwd: btrfs problems To: linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-btrfs-owner@vger.kernel.org List-ID: Hi Chris > There's almost no useful information provided for someone to even try > to reproduce your results, isolate cause and figure out the bugs. I realize that. That's why I wasn't really asking for help, I was merely giving some feedback. > No kernel version. No btrfs-progs version. No description of the > hardware and how it's laid out, and what mkfs and mount options are > being used. No one really has the time to speculate. I understand, and I apologize. I could have added more detail. > > >BTRFS check --repair is not recommended > > Right. So why did you run it anyway? Because "repair" implies it does something to help you. That's how most people's brains work. My fs is broken. I'll try "REPAIR" > man btrfs check: > > Warning > Do not use --repair unless you are advised to do so by a > developer or an experienced user > > > It is always a legitimate complaint, despite this warning, if btrfs > check --repair makes things worse, because --repair shouldn't ever > make things worse. I don't think It made things worse. It's more like it didn't do anything. That's when I started trying to copy a new file to the file with the question mark attributes (lame, I know) to see what happens. The "corrupted" file suddenly had attributes, and so on. check --repair removed the extra files and left me at square one, so not worse. >But Btrfs repairs are complicated, and that's why > the warning is there. I suppose the devs could have made the flag > --riskyrepair but I doubt this would really slow users down that much. calling it --destructive or --deconstruct, or something even more scary would slow people down > A big part of --repair fixes weren't known to make things worse at the > time, and edge cases where it made things worse kept popping up, so > only in hindsight does it make sense --repair maybe could have been > called something different to catch the user's attention. Exactly. It's not too late to rename it. And maybe make it dump a filesystem report with everything a developer would need (within reason) to trace the error > But anyway, I see this same sort of thing on the linux-raid list all > the time. People run into trouble, and they press full forward making > all kinds of changes, each change increases the chance of data loss. > And then they come on the list with WTF messages. And it's always a > lesson in patience for the list regulars and developers... if only > you'd come to us with questions sooner. True. I found the list a bit late. I tried the IRC channel but I couldn' t post messages. > > Please have a look at the console logs. > > These aren't logs. It's a record of shell commands. Logs would include > kernel messages, ideally all of them. Why is device 3 missing? It was a RAID5 array of three drives. When doing btrfs check on two of the drives I got the drive x is missing. I figured that maybe it had to do something with which one was the "first" drive or something. The same way, btrfs-check crashed when I was running it against the drives where I got the "drive x missing" message > We have no idea. Most of Btrfs code is in the kernel, problems are reported by > the kernel. So we need kernel messages, user space messages aren't > enough. > Anyway, good luck with openzfs, cool project. Cool project, not so cool pitfalls. I might head back to BTRFS after all .. see the response to Qu. Thanks for answering, and sorry for the shortcomings of my feedback /A > > -- > Chris Murphy -- Vänliga hälsningar / Kind regards, Adrian Bastholm ``I would change the world, but they won't give me the sourcecode`` -- Vänliga hälsningar / Kind regards, Adrian Bastholm ``I would change the world, but they won't give me the sourcecode``