From: Dimitri John Ledkov <xnox@debian.org>
To: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 4/4] Default to acting like fsck.
Date: Mon, 22 Sep 2014 09:58:34 +0100 [thread overview]
Message-ID: <CANBHLUghtYatMgdGHDunp4osE16Ve2urTcmK9u963scOgiFwHg@mail.gmail.com> (raw)
In-Reply-To: <CAKFHe2RwgjBDCEd6D4jva8QFou=gj8Pzd2auFUNyHFNephrYTw@mail.gmail.com>
On 21 September 2014 13:59, Tobias Geerinckx-Rice
<tobias.geerinckx.rice@gmail.com> wrote:
> On 21 September 2014 03:01, Dimitri John Ledkov <xnox@debian.org> wrote:
>>
>> Inspect arguments, if we are not called as btrfs, then assume we are
>> called to act like fsck.
> [...]
>> - if (!strcmp(bname, "btrfsck")) {
>> + if (strcmp(bname, "btrfs") != 0) {
>
> That's assuming a lot.
>
> Silently (!) breaking people's btrfs-3.15_patched-DontRandomlyPanicV2
> is a recipe for needless hair-pulling. Is there a reason for not using
> something less like strstr(bname, "fsck") that I am missing?
>
Quite. This is verbatim patch as I have currently applied in Debian
packaging, and it was a fast fix to prevent breakage we had at one
point.
Indeed using "strstr(bname, "fsck")" would be better and sufficient to
resolve the problem we encountered (specifically fsck.btrfs -> btrfs
not acting like btrfs). Also using strstr, would fix btrfsck.my-build
to act like fsck tool.
I'll update this one patch.
--
Regards,
Dimitri.
next prev parent reply other threads:[~2014-09-22 8:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 1:01 [PATCH 1/4] Properly cast to avoid compiler warnings, fixes FTBFS on alpha and ia64 Dimitri John Ledkov
2014-09-21 1:01 ` [PATCH 2/4] Fixes FTBFS with --no-add-needed Dimitri John Ledkov
2014-09-22 12:23 ` David Sterba
2014-09-21 1:01 ` [PATCH 3/4] Fixing unaligned memory accesses Dimitri John Ledkov
2014-09-22 13:03 ` David Sterba
2014-09-21 1:01 ` [PATCH 4/4] Default to acting like fsck Dimitri John Ledkov
2014-09-21 12:59 ` Tobias Geerinckx-Rice
2014-09-22 8:58 ` Dimitri John Ledkov [this message]
2014-09-22 13:13 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANBHLUghtYatMgdGHDunp4osE16Ve2urTcmK9u963scOgiFwHg@mail.gmail.com \
--to=xnox@debian.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=tobias.geerinckx.rice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).