From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f68.google.com ([209.85.214.68]:36115 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725850AbeIFKTh (ORCPT ); Thu, 6 Sep 2018 06:19:37 -0400 Received: by mail-it0-f68.google.com with SMTP id u13-v6so12676494iti.1 for ; Wed, 05 Sep 2018 22:45:53 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1536110090-100798-1-git-send-email-bo.liu@linux.alibaba.com> References: <1536110090-100798-1-git-send-email-bo.liu@linux.alibaba.com> From: Liu Bo Date: Wed, 5 Sep 2018 22:45:52 -0700 Message-ID: Subject: Re: [PATCH] Btrfs: remove redundant btrfs_trans_release_metadata" To: Liu Bo Cc: linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-btrfs-owner@vger.kernel.org List-ID: Somehow this ends up with crash in btrfs/124, I'm trying to figure out what went wrong. thanks, liubo On Tue, Sep 4, 2018 at 6:14 PM, Liu Bo wrote: > __btrfs_end_transaction() has done the metadata release twice, > probably because it used to process delayed refs in between, but now > that we don't process delayed refs any more, the 2nd release is always > a noop. > > Signed-off-by: Liu Bo > --- > fs/btrfs/transaction.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c > index bb1b9f526e98..94b036a74d11 100644 > --- a/fs/btrfs/transaction.c > +++ b/fs/btrfs/transaction.c > @@ -826,12 +826,6 @@ static int __btrfs_end_transaction(struct btrfs_trans_handle *trans, > return 0; > } > > - btrfs_trans_release_metadata(trans); > - trans->block_rsv = NULL; > - > - if (!list_empty(&trans->new_bgs)) > - btrfs_create_pending_block_groups(trans); > - > trans->delayed_ref_updates = 0; > if (!trans->sync) { > must_run_delayed_refs = > -- > 1.8.3.1 >