public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: ZhengYuan Huang <gality369@gmail.com>
To: Qu Wenruo <wqu@suse.com>
Cc: dsterba@suse.com, clm@fb.com, linux-btrfs@vger.kernel.org,
	 linux-kernel@vger.kernel.org, baijiaju1990@gmail.com,
	r33s3n6@gmail.com,  zzzccc427@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: reject root items with drop_progress and zero drop_level
Date: Thu, 12 Mar 2026 12:27:13 +0800	[thread overview]
Message-ID: <CAOmEq9Xj1+S1oDXaNEP3rWyG9DOd4LWm7sd3P5Ub86Fdx6Tgog@mail.gmail.com> (raw)
In-Reply-To: <a478f7a7-5255-4039-9ace-7d2b410db602@suse.com>

On Thu, Mar 12, 2026 at 12:16 PM Qu Wenruo <wqu@suse.com> wrote:
> > My understanding had been that patches should generally be sent only
> > after passing
> > checkpatch.pl cleanly,
>
> No, that is only a script which has its limits.
> Checkpatch is good for its code style checks, but not always correct on
> other suggestions.
>
> Sometimes even its code style checks may conflict with the rules inside
> each subsystem.

Thanks for the clarification.

Understood, that makes sense. I had been treating checkpatch.pl
warnings too strictly. I'll follow the documented guidelines and
subsystem expectations instead.

Thanks again,
ZhengYuan Huang

      reply	other threads:[~2026-03-12  4:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12  0:14 [PATCH v2] btrfs: reject root items with drop_progress and zero drop_level ZhengYuan Huang
2026-03-12  0:23 ` Qu Wenruo
2026-03-12  1:07   ` Qu Wenruo
2026-03-12  2:10     ` ZhengYuan Huang
2026-03-12  4:16       ` Qu Wenruo
2026-03-12  4:27         ` ZhengYuan Huang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOmEq9Xj1+S1oDXaNEP3rWyG9DOd4LWm7sd3P5Ub86Fdx6Tgog@mail.gmail.com \
    --to=gality369@gmail.com \
    --cc=baijiaju1990@gmail.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=r33s3n6@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=wqu@suse.com \
    --cc=zzzccc427@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox